Correctly preserve original basic-save-buffer.
#199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*monkey-patch.el* was defining an alias `live-mp-orig-basic-save-buffer` which wasz bound to the symbol `basic-save-buffer`. After redefining `basic-save-buffer` with the call `(defalias 'basic-save-buffer 'live-mp-new-basic-save-buffer)`, both `basic-save-buffer` and `live-mp-orig-basic-save-buffer` were both bound to the function `live-mp-new-basic-save-buffer`. Instead, the backup alias should be bound to the function directly, not the symbol.
|
Forgot to mention in my original pull request, but the reason this is needed is to be able to revert the functionality of |
rothmichaels
added a commit
to rothmichaels/emacs-live
that referenced
this pull request
May 21, 2015
samaaron
added a commit
that referenced
this pull request
Jul 8, 2015
Correctly preserve original `basic-save-buffer`.
|
Good call, thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
monkey-patch.el was defining an alias
live-mp-orig-basic-save-bufferwhich was bound to the symbol
basic-save-buffer. After redefiningbasic-save-bufferwith the call(defalias 'basic-save-buffer 'live-mp-new-basic-save-buffer), bothbasic-save-bufferandlive-mp-orig-basic-save-bufferwere both bound to the functionlive-mp-new-basic-save-buffer.Instead, the backup alias should be bound to the function directly, not
the symbol.