[PoC] add diff support for diff strategy #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry, I've been busy these days, I'll come back to double-check this when I'm done, or @mutschler @mansoorkhan96 can help to see how to fix it! |
|
I will check in a few days. |
overtrue
added a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ment to be merged, as im not sure if the if/else part at the beginning is really needed. For some reason i did it that way but i can't recall why (was pretty late)
this is ment to be more of a PoC to make the Diff Class with the Diff VersionStrategy. Thought i'd share it if someone want's to improve it
see mansoorkhan96/filament-versionable#10 and maybe even mansoorkhan96/filament-versionable#8