Fix total votes scope to remove redundant DB query #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to get something like
Idea::withTotalVotes()->get()
the attribute
total_votes
can be null if there are no votes, which will result in additional query because of this fallbacklaravel-vote/src/Traits/Votable.php
Line 77 in f06ad18
i suggest to use
COALESCE
to make it zero when no records are found