206 - Refactor nav #211
Merged
206 - Refactor nav #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joneubank
reviewed
May 31, 2022
| @@ -7,3 +7,13 @@ export enum ResourceType { | |||
| API_KEYS = 'API Keys', | |||
| POLICIES = 'policies', | |||
| } | |||
|
|
|||
| // TODO: added this for now to make compiler happy | |||
joneubank
reviewed
May 31, 2022
src/components/AppProviders.tsx
Outdated
Comment on lines
10
to
11
| // import { EntityProvider } from './global/hooks/useEntityContext'; | ||
| // import RESOURCE_MAP from 'common/RESOURCE_MAP'; |
src/components/Nav/Nav.tsx
Outdated
| | ResourceType.POLICIES; | ||
|
|
||
| const iconStyle = { opacity: 0.9 }; | ||
| const navIcons: { [key in ParentResource]: () => ReactElement } = { |
There was a problem hiding this comment.
Slightly cleaner type description: const navIcons: Record<ParentResource, ()=>ReactEelement> . Just tested it as functionally equivalent to what you used but it cleans up the TS linter messages when there are keys missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes resource map references in Nav. Main changes in
Nav.tsxandApp.tsxsubResourceId, ui doesn't use this level of nesting anymore. renamessubResourceNametochildResourceName