Parent table with params #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| setListState(data); | ||
| } | ||
| }, [resourceName, currentListParams]); | ||
| const setListParams = useMemo( |
There was a problem hiding this comment.
not sure why we're using useMemo here?
|
|
||
| // from https://usehooks.com/useDebounce/ | ||
|
|
||
| const useDebounce = <T,>(value: T, delay: number): T => { |
There was a problem hiding this comment.
<T,> ? weird. prettier checks out though
There was a problem hiding this comment.
yeah i just lazily copied it...we have it in dac-ui too 🤷♀️
src/components/ListPane/ListPane.tsx
Outdated
| @@ -148,7 +152,9 @@ const List = () => { | |||
| backgroundColor: 'transparent', | |||
| ...(listParams.sortOrder === 'DESC' && { color: theme.colors.primary_5 }), | |||
| }} | |||
| // onClick={() => setListParams({ ...listParams, sortOrder: 'DESC' })} | |||
| onClick={() => | |||
| setListParams({ sortOrder: listParams.sortOrder === 'ASC' ? 'DESC' : 'ASC' }) | |||
There was a problem hiding this comment.
worth putting 'ASC' and 'DESC' into enum? used a fair bit
There was a problem hiding this comment.
Funny I thought I did have one, and forgot to use it here...but will do!
There was a problem hiding this comment.
Nvmd i def do, it was just a type instead of an enum...will use it here!
ciaranschutte
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds parameters to list context