Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLM uses radians since 0.9.6.0 #35

Closed
Mischa-Alff opened this issue Feb 23, 2015 · 1 comment
Closed

GLM uses radians since 0.9.6.0 #35

Mischa-Alff opened this issue Feb 23, 2015 · 1 comment

Comments

@Mischa-Alff
Copy link
Contributor

Since version 0.9.6.0, GLM broke compatibility with previous versions to use radians instead of degrees.

I'd gladly make a PR to fix this in the code/articles, but I was wondering if it was more desirable to do e.g glm::radians(45.0f), or simply 3.1415f/4.f, or use const float pi = std::acos(-1);, and do pi/4.f?

I personally think glm::radians(45.0f) is more understandable/readable to someone who is new to graphics programming and/or inexperienced in trigonometry.

@Overv
Copy link
Owner

Overv commented Feb 23, 2015

Yes, glm::radians would make the most sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants