Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB] JS Fixes #1456

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@DevScyu
Copy link

commented May 20, 2018

Added support for Polygons, Polylines and Fixed a bug where you could scroll to a minimum zoom level of 0, even if in the config it was set at a higher number.

Fixed the code for

overviewer.util.ready(function(){
    // do stuff
});

See the changes in action: http://wynndata.tk/map/

DevScyu added some commits May 20, 2018

Add Region back to Coord Box
Was removed for my custom map

@DevScyu DevScyu changed the title Markers, Polygons, Polylines and fixed Zooming past minZoom in config. [WEB] JS Fixes May 21, 2018

DevScyu added some commits May 21, 2018

Removed useless code and added checked for default loading
Groups that have checked: true will be enabled when page loads.
@r15ch13

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2018

👍 for the overviewer.util.ready(); fix

@CounterPillow

This comment has been minimized.

Copy link
Member

commented Jun 14, 2018

Sorry that I haven't gotten around to reviewing this yet, I'll try to get it done within the next 7 days.

@DevScyu

This comment has been minimized.

Copy link
Author

commented Jun 18, 2018

I have been working on the Leaflet map for a while so any questions or changes feel free to ask.

@SkylixMC

This comment has been minimized.

Copy link

commented Aug 22, 2018

In reference to the bug where you could zoom past the number set in the config, though now it is fixed for the most part, still if you switch to another world, the world loads so it IS zoomed past the min zoom. You have to zoom back in to fix it.

@CounterPillow
Copy link
Member

left a comment

On first look, indentation is all wrong, so I can't merge it in its current state. Please adjust your editor settings.

if ((typeof markers !== 'undefined') && (obj.path in markers)) {
console.log("haveSigns = true");
console.log(obj);
test = obj;

This comment has been minimized.

Copy link
@CounterPillow

CounterPillow Nov 26, 2018

Member

What is this and why is it here?

* there is only one open at a time.
*/
'infoWindow': null,
/**

This comment has been minimized.

Copy link
@CounterPillow

CounterPillow Nov 26, 2018

Member

Please indent with 4 spaces to keep it consistent

let new_marker = new L.marker(latlng, {icon: m_icon});
new_marker.bindPopup(db.text);
marker_group.addLayer(new_marker);
var entity = markersDB[marker_entry.groupName].raw;

This comment has been minimized.

Copy link
@CounterPillow

CounterPillow Nov 26, 2018

Member

random tab indented thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.