[WEB] JS Fixes #1456
Closed
[WEB] JS Fixes #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was removed for my custom map
DevScyu
changed the title
Groups that have checked: true will be enabled when page loads.
This can be done using Leaflet Popups. https://leafletjs.com/reference-1.3.0.html#popup
|
👍 for the |
|
Sorry that I haven't gotten around to reviewing this yet, I'll try to get it done within the next 7 days. |
|
I have been working on the Leaflet map for a while so any questions or changes feel free to ask. |
|
In reference to the bug where you could zoom past the number set in the config, though now it is fixed for the most part, still if you switch to another world, the world loads so it IS zoomed past the min zoom. You have to zoom back in to fix it. |
CounterPillow
requested changes
Nov 26, 2018
| if ((typeof markers !== 'undefined') && (obj.path in markers)) { | ||
| console.log("haveSigns = true"); | ||
| console.log(obj); | ||
| test = obj; |
There was a problem hiding this comment.
What is this and why is it here?
| * there is only one open at a time. | ||
| */ | ||
| 'infoWindow': null, | ||
| /** |
There was a problem hiding this comment.
Please indent with 4 spaces to keep it consistent
| let new_marker = new L.marker(latlng, {icon: m_icon}); | ||
| new_marker.bindPopup(db.text); | ||
| marker_group.addLayer(new_marker); | ||
| var entity = markersDB[marker_entry.groupName].raw; |
There was a problem hiding this comment.
random tab indented thing
deltaidea
added a commit
to deltaidea/Minecraft-Overviewer
that referenced
this pull request
Sep 25, 2019
Add support for polyline POIs just like in the good ol' Google Maps days. See overviewer#883. The format after this commit is: { id, x, y, z, text, color, polyline/polygon: [{ x, y, z }, ...] } Optional properties: - common ones like "icon" and "hovertext" - "strokeColor" (string), - "fill" (boolean) - "weight" (integer) Docs not included. Largely based on PR overviewer#1536 by @jsmienk. Closes overviewer#1456, closes overviewer#1536, closes overviewer#1643.
deltaidea
added a commit
to deltaidea/Minecraft-Overviewer
that referenced
this pull request
Sep 25, 2019
Add support for polyline POIs just like in the good ol' Google Maps days. See overviewer#883. The format after this commit is: { id, x, y, z, text, color, polyline/polygon: [{ x, y, z }, ...] } Optional properties: - common ones like "icon" and "hovertext" - "strokeColor" (string), - "fill" (boolean) - "weight" (integer) Docs not included. Largely based on PR overviewer#1536 by @jsmienk. Closes overviewer#1456, closes overviewer#1536, closes overviewer#1643.
deltaidea
added a commit
to deltaidea/Minecraft-Overviewer
that referenced
this pull request
Sep 25, 2019
Add support for polyline POIs just like in the good ol' Google Maps days. See overviewer#883. The format after this commit is: { id, x, y, z, text, color, polyline/polygon: [{ x, y, z }, ...] } Optional properties: - common ones like "icon" and "hovertext" - "strokeColor" (string), - "fill" (boolean) - "weight" (integer) Docs not included. Largely based on PR overviewer#1536 by @jsmienk. Closes overviewer#1456, closes overviewer#1536, closes overviewer#1643.
deltaidea
added a commit
to deltaidea/Minecraft-Overviewer
that referenced
this pull request
Nov 1, 2019
Add support for polyline POIs just like in the good ol' Google Maps days. See overviewer#883. The format after this commit is: { id, x, y, z, text, color, polyline/polygon: [{ x, y, z }, ...] } Optional properties: - common ones like "icon" and "hovertext" - "strokeColor" (string), - "fill" (boolean) - "weight" (integer) Docs not included. Largely based on PR overviewer#1536 by @jsmienk. Closes overviewer#1456, closes overviewer#1536, closes overviewer#1643.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Polygons, Polylines and Fixed a bug where you could scroll to a minimum zoom level of 0, even if in the config it was set at a higher number.
Fixed the code for
See the changes in action: http://wynndata.tk/map/