Do not panic on unsupported compression type #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An unsupported compression type can legitimately happen when we catch a region in the middle of a server updating it. This error can be nicely handled by simply retrying the read, but the panic disallows this. Instead of panicking, simply introduce a new error type and return it when we encounter such a case.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya folks, it's me again.
An unsupported compression type can legitimately happen when we catch a region in the middle of a server updating it. This error can be nicely handled by simply retrying the read, but the panic disallows this.
Instead of panicking, this PR simply introduces a new error type and returns it when we encounter such a case.