Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typeof owad #64

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add typeof owad #64

wants to merge 5 commits into from

Conversation

Kyusung4698
Copy link
Contributor

  • added overwolf.settings.hotkey.update
  • updated global window to include typeof owad

@OdedItkinOW
Copy link
Collaborator

OdedItkinOW commented Dec 6, 2022

for the 208 part - will be updated later this week most likely
for the ads part added afterwards - might have to roll back this one. as part of the ads sdk docs re-write (still under review), we're gonna overhaul the types to fit, but not sure just yet if I approve of this specific approach.

either way, thank you for the pr!

@Kyusung4698
Copy link
Contributor Author

Thanks for the review! I've reverted the owad changes. Feel free to merge whenever.

OdedItkinOW added a commit that referenced this pull request Feb 26, 2023
@OdedItkinOW
Copy link
Collaborator

On hindsight most of this pr was applied already due to something else. Leaving it open since the Ads thing might still be a good idea to fix.

@OdedItkinOW OdedItkinOW changed the title v208 Add typeof owad May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants