fix(api): compute workflow v3 preview (#6346)

ovh · Oct 21, 2022 · 0bc7a67 · 0bc7a67
1 parent 382bf78
commit 0bc7a67
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/engine/api/workflow.go b/engine/api/workflow.go
@@ -219,6 +219,9 @@ func (api *API) getWorkflowHandler() service.Handler {
 		vars := mux.Vars(r)
 		key := vars["key"]
 		name := vars["permWorkflowNameAdvanced"]
+		if name == "" {
+			name = vars["permWorkflowName"] // Useful for workflowv3 routes
+		}
 		withUsage := service.FormBool(r, "withUsage")
 		withAudits := service.FormBool(r, "withAudits")
 		withLabels := service.FormBool(r, "withLabels")

diff --git a/engine/api/workflow/dao.go b/engine/api/workflow/dao.go
@@ -257,6 +257,10 @@ func Load(ctx context.Context, db gorp.SqlExecutor, _ cache.Store, proj sdk.Proj
 	ctx, end := telemetry.Span(ctx, "workflow.Load")
 	defer end()
 
+	if name == "" {
+		return nil, sdk.NewErrorFrom(sdk.ErrInvalidData, "invalid given workflow name")
+	}
+
 	dao := opts.GetWorkflowDAO()
 	dao.Filters.ProjectKey = proj.Key
 	dao.Filters.WorkflowName = name

diff --git a/engine/api/workflow_run.go b/engine/api/workflow_run.go
@@ -266,6 +266,9 @@ func (api *API) getWorkflowRunHandler() service.Handler {
 		vars := mux.Vars(r)
 		key := vars["key"]
 		name := vars["permWorkflowNameAdvanced"]
+		if name == "" {
+			name = vars["permWorkflowName"] // Useful for workflowv3 routes
+		}
 		number, err := requestVarInt(r, "number")
 		if err != nil {
 			return err