fix(ui): hide diff when audit is too big (#4834)

ovh · Dec 20, 2019 · 9dd31c2 · 9dd31c2
1 parent f53d196
commit 9dd31c2
Show file tree

Hide file tree

Showing 4 changed files with 1,432 additions and 1,427 deletions.
diff --git a/ui/src/app/shared/diff/item/diff.item.component.ts b/ui/src/app/shared/diff/item/diff.item.component.ts
@@ -104,7 +104,9 @@ export class DiffItemComponent implements OnInit, OnChanges {
         if (this.original || this.updated) {
             this.refresh();
         }
-        this.codeMirrorConfig.mode = this.type;
+        if (this.codeMirrorConfig) {
+            this.codeMirrorConfig.mode = this.type;
+        }
     }
 
     refresh() {
@@ -126,7 +128,7 @@ export class DiffItemComponent implements OnInit, OnChanges {
             } catch (e) { }
         }
 
-        let diff = JsDiff.diffLines(original, updated);
+        let diff = JsDiff.diffLines(original + '', updated + '');
 
         if (!Array.isArray(diff)) {
             return;

diff --git a/ui/src/app/shared/diff/list/diff.list.html b/ui/src/app/shared/diff/list/diff.list.html
@@ -4,12 +4,13 @@
     <button class="ui button" (click)="setSplit()" [class.active]="mode === 'split'">{{'common_split'
         | translate}}</button>
 </div>
-<ng-container *ngFor="let i of items">
+<ng-container *ngFor="let i of items;let idx = index">
     <h4 class="ui top attached header">
         <ng-container *ngIf="i.name">{{i.name}}</ng-container>
         <ng-container *ngIf="i.translate">{{i.translate | translate: i.translateData}}</ng-container>
     </h4>
     <div class="ui attached segment">
-        <app-diff-item [mode]="mode" [type]="i.type" [original]="i.before" [updated]="i.after"></app-diff-item>
+        <app-diff-item *ngIf="idx < 10" [mode]="mode" [type]="i.type" [original]="i.before" [updated]="i.after"></app-diff-item>
+        <ng-container *ngIf="idx >= 10">{{'common_diff_to_much_item' | translate}}</ng-container>
     </div>
 </ng-container>