fix(kafka-publish): don't fail silently (#3343)

Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
ovh · Sep 20, 2018 · cee0195 · cee0195
1 parent 2486ab4
commit cee0195
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/contrib/grpcplugins/action/kafka-publish/main.go b/contrib/grpcplugins/action/kafka-publish/main.go
@@ -199,10 +199,7 @@ func (actPlugin *kafkaPublishActionPlugin) Run(ctxBack context.Context, q *actio
 
 	Logf("Ack Received: %+v\n", ack)
 
-	return &actionplugin.ActionResult{
-		Status:  sdk.StatusSuccess.String(),
-		Details: fmt.Sprintf("Plugin failed with ACK.Result:%s", ack.Result),
-	}, nil
+	return fail("Plugin failed with ACK.Result:%s", ack.Result)
 }
 
 func (actPlugin *kafkaPublishActionPlugin) WorkerHTTPPort(ctx context.Context, q *actionplugin.WorkerHTTPPortQuery) (*empty.Empty, error) {