fix(worker): add error line number #3068 #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
sguiheux
approved these changes
Jul 24, 2018
fsamin
requested changes
Jul 24, 2018
| @@ -155,7 +155,7 @@ func (w *currentWorker) runJob(ctx context.Context, a *sdk.Action, buildID int64 | |||
| return sdk.Result{ | |||
| Status: sdk.StatusFail.String(), | |||
| BuildID: buildID, | |||
| Reason: "Unable to interpolate action parameters", | |||
| Reason: err.Error(), | |||
There was a problem hiding this comment.
i suggest: "Unable to interpolate action parameters (%v)", err
There was a problem hiding this comment.
no, because in the error of interpolate there is already Unable to interpolate action parameters so in fact the final sentence is for example : Unable to interpolate action parameters: Invalid template format: template: input:17
fsamin
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Benjamin Coenen benjamin.coenen@corp.ovh.com
close feature request: give the position of a bad interpolation in script (syntax error) #3068
cc @pgaxatte
@ovh/cds