Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(worker): add error line number #3068 #3069

Merged
merged 1 commit into from Jul 25, 2018
Merged

fix(worker): add error line number #3068 #3069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion engine/worker/run.go
View file
Open in desktop
Expand Up @@ -155,7 +155,7 @@ func (w *currentWorker) runJob(ctx context.Context, a *sdk.Action, buildID int64
return sdk.Result{
Status: sdk.StatusFail.String(),
BuildID: buildID,
Reason: "Unable to interpolate action parameters",
Reason: err.Error(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i suggest: "Unable to interpolate action parameters (%v)", err

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, because in the error of interpolate there is already Unable to interpolate action parameters so in fact the final sentence is for example : Unable to interpolate action parameters: Invalid template format: template: input:17

}
}
// Set the params
Expand Down