Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ascode: yml with hook #3239

Closed
yesnault opened this issue Aug 22, 2018 · 0 comments · Fixed by #3423
Closed

ascode: yml with hook #3239

yesnault opened this issue Aug 22, 2018 · 0 comments · Fixed by #3423
Assignees
@fsamin

Comments

@yesnault
Copy link
Member

when we import a workflow as code, CDS creates automatically 1 repository webhook. No need to explicitly add the repowebhook in yml.

But, if user add a repoWebhook as yml below, we should have 2 repowebhook: one for the ascode, another for the user repowebhook. Actually, there is only once visible on UI (same uid) and two webhooks with same uuid on repo manager.

name: thewf
version: v1.0
workflow:
  ci:
    pipeline: ci
    application: theapp
    payload:
      git.author: ""
      git.branch: master
      git.hash: ""
      git.hash.before: ""
      git.message: ""
      git.repository: FOO/bar
hooks:
  ci:
    - type: RepositoryWebHook
metadata:
  default_tags: git.branch,git.author,git.hash
@fsamin fsamin self-assigned this Oct 8, 2018
fsamin added a commit that referenced this issue Oct 8, 2018
@fsamin
wip fix #3239
2546453
fsamin added a commit that referenced this issue Oct 8, 2018
@fsamin
fix #3239
cac3ab6
fsamin added a commit that referenced this issue Oct 9, 2018
@fsamin
fix(api): workflow as code improvements
b8402f7 
* Since a hook is mandatory for workflow as code, do not export it
* Do not export default VCS payload

closes #3239
@fsamin fsamin mentioned this issue Oct 9, 2018
Merged
fsamin added a commit that referenced this issue Oct 10, 2018
@fsamin
wip fix #3239
9a0c04d
fsamin added a commit that referenced this issue Oct 10, 2018
@fsamin
fix #3239
d3a18dd
fsamin added a commit that referenced this issue Oct 10, 2018
@fsamin
fix(api): workflow as code improvements
1f680e1 
* Since a hook is mandatory for workflow as code, do not export it
* Do not export default VCS payload

closes #3239
fsamin added a commit that referenced this issue Oct 10, 2018
@fsamin
fix(api): workflow as code improvements (#3423)
4d80334 
* Since a hook is mandatory for workflow as code, do not export it
* Do not export default VCS payload

closes #3239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsamin fsamin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(api): workflow as code improvements ovh/cds
2 participants
@yesnault @fsamin