Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): do not permit uppercase in service requirement name #3241

Closed
bnjjj opened this issue Aug 22, 2018 · 0 comments · Fixed by #3247
Closed

fix(api): do not permit uppercase in service requirement name #3241

bnjjj opened this issue Aug 22, 2018 · 0 comments · Fixed by #3247
Labels
bug

Comments

@bnjjj
Copy link
Contributor

bnjjj commented Aug 22, 2018

Because in kubernetes we can't give as a dns name a camelCase name
@bnjjj bnjjj added the bug label Aug 22, 2018
bnjjj added a commit that referenced this issue Aug 22, 2018
@bnjjj
fix(hatchery): lower case on service requirement name for kubernetes
ed25d0d 
close #3241
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@bnjjj bnjjj mentioned this issue Aug 22, 2018
Merged
yesnault pushed a commit that referenced this issue Aug 22, 2018
@bnjjj @yesnault
fix(hatchery): lower case on service requirement name for kubernetes (#…
016369c 
…3247)

close #3241
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(hatchery): lower case on service requirement name for kubernetes ovh/cds
1 participant
@bnjjj