Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(contrib): fix postgres dependency condition #4058

Merged
merged 1 commit into from
Mar 25, 2019
Merged

fix(contrib): fix postgres dependency condition #4058

merged 1 commit into from
Mar 25, 2019

Conversation

thudry
Copy link
Contributor

@thudry thudry commented Mar 19, 2019

  1. Description
    This change will prevent the embedded postgres to be deployed when the user want to use an external database.
  2. Related issues
    helm - postgres is always deployed even when an external database is used  #4057
  3. About tests
  4. Mentions

@ovh/cds

fix(contrib): fix postgres dependency condition
dcf9f91 
Signed-off-by: Thomas Hudry <thomas.hudry@gmail.com>
fsamin
fsamin approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@fsamin fsamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks for your contribution

@bnjjj bnjjj merged commit 1ae2ad3 into ovh:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@sguiheux sguiheux sguiheux approved these changes

@richardlt richardlt richardlt approved these changes

@bnjjj bnjjj bnjjj approved these changes

Assignees
No one assigned
Labels
packaging&distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thudry @yesnault @fsamin @sguiheux @richardlt @bnjjj