feat(ui): change style about navbar #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
sguiheux
requested changes
Mar 20, 2018
ui/package.json
Outdated
| @@ -59,7 +59,7 @@ | |||
| "ng2-codemirror-typescript": "^1.1.1", | |||
| "ng2-completer": "^1.4.0", | |||
| "ng2-dragula": "^1.2.1", | |||
| "ng2-semantic-ui": "^0.9.6", | |||
| "ng2-semantic-ui": "git://github.com/bnjjj/ng2-semantic-ui.git#feat_search_empty_query", | |||
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
yesnault
approved these changes
Mar 21, 2018
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
|
remove space between navbar and list of project |
|
in all projects list:
|
Signed-off-by: Benjamin Coenen <benjamin.coenen@hotmail.com>
Signed-off-by: Benjamin Coenen <benjamin.coenen@hotmail.com>
Signed-off-by: Benjamin Coenen <benjamin.coenen@hotmail.com>
|
when we load navbar, we should refresh recently viewed (to not display something renamed or deleted) |
|
@yesnault will be done in another PR for resync with deletions |
|
ready to merge |
yesnault
approved these changes
Mar 22, 2018
sguiheux
approved these changes
Mar 23, 2018
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
Signed-off-by: Benjamin Coenen <benjamin.coenen@hotmail.com>
Signed-off-by: Benjamin Coenen <benjamin.coenen@hotmail.com>
|
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: change in package.json
Signed-off-by: Benjamin Coenen benjamin.coenen@corp.ovh.com