feat(api,sdk,ui): deprecated worker models #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: François Samin <francois.samin@corp.ovh.com>
yesnault
requested changes
Mar 23, 2018
ui/src/assets/i18n/fr.json
Outdated
| "worker_model_is_deprecated": "Modèle de worker déprécié", | ||
| "worker_model_deprecated_help": "Indique que ce modèle de worker est déprécié", | ||
| "worker_model_deprecated_tooltip": "Ce modèle de worker est déprécié", | ||
| "worker_model_official_tooltip": "Modèle de worker official maintenu par les administrateurs de CDS", |
| <span *ngIf="v.disabled==='true'"> {{ 'worker_model_disabled' | translate }}</span> | ||
| <div class="ui"> | ||
| {{v.name}} | ||
| <span *ngIf="v.disabled"> {{ 'worker_model_disabled' | translate }}</span> | ||
| <span *ngIf="v.nb_spawn_err > 0"> <i class="warning sign icon orange" title="{{ 'worker_model_warning' | translate }}"></i> </span> |
There was a problem hiding this comment.
can you use smDirTooltip on v.nb_spawn_err > 0 too? This icon (warning sign) does not have a great icon (not same size) nor a great tooltip.
yesnault
requested changes
Mar 24, 2018
| </div> | ||
| <div class="ui two wide column valign"> | ||
| <span *ngIf="getWorkerModel(r.value)?.is_official" [smDirTooltip]="'worker_model_official_tooltip' | translate" smDirPosition="top center"><i class="check circle outline icon large green"></i></span> | ||
| <span *ngIf="getWorkerModel(r.value)?.is_deprecated" [smDirTooltip]="'worker_model_deprecated_tooltip' | translate" smDirPosition="top center"><i class="exclamation circle icon large orange"></i></span> |
There was a problem hiding this comment.
if too many error with a worker model (5) -> status is disabled. It would be useful to user to see that the selected worker model is disabled in job requirements. So, it should be great to have an icon for the status disabled or not, as deprecated and official.
sguiheux
requested changes
Mar 26, 2018
| @@ -18,37 +18,30 @@ <h2>{{ 'worker_model_list_title' | translate }}</h2> | |||
| <table class="ui fixed celled table" *ngIf="getDataForCurrentPage().length > 0"> | |||
| <thead> | |||
| <tr> | |||
| <th class="three wide">{{ 'worker_model_name' | translate }}</th> | |||
There was a problem hiding this comment.
not your fault but sum of column wide must be equal to 16
yesnault
requested changes
Mar 26, 2018
ui/src/assets/i18n/fr.json
Outdated
| @@ -641,7 +641,8 @@ | |||
| "worker_model_is_deprecated": "Modèle de worker déprécié", | |||
| "worker_model_deprecated_help": "Indique que ce modèle de worker est déprécié", | |||
| "worker_model_deprecated_tooltip": "Ce modèle de worker est déprécié", | |||
| "worker_model_official_tooltip": "Modèle de worker official maintenu par les administrateurs de CDS", | |||
| "worker_model_official_tooltip": "Modèle de worker officiel maintenu par les administrateurs de CDS", | |||
| "worker_model_spawn_error_tooltip": "Modèle est erreur", | |||
bnjjj
approved these changes
Mar 26, 2018
yesnault
approved these changes
Mar 26, 2018
sguiheux
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: François Samin francois.samin@corp.ovh.com
Description
Add ability to set worker model as deprecated ans display this information while selecting model"
Related issues
n/a
About tests
done manually
Mentions
@ovh/cds