Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (engine,ui): allow provisioning for restricted wm #2459

Merged
merged 4 commits into from
Mar 27, 2018
Merged

feat (engine,ui): allow provisioning for restricted wm #2459

merged 4 commits into from
Mar 27, 2018

Conversation

yesnault
Copy link
Member

@yesnault yesnault commented Mar 23, 2018 •
edited

  1. Description
  • user is allowed to set provision on a restricted worker model
  • a default group can be a owner of a worker model

  1. Related issues
    n/a

  2. About tests
    Manual done

  3. Mentions
    it's for you @henyxia

@yesnault yesnault changed the title 1. Description feat (engine,ui): allow provisioning for restricted wm Mar 23, 2018
fsamin
fsamin requested changes Mar 26, 2018
View reviewed changes
Copy link
Member

@fsamin fsamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a unit tests about this, at least to remember the how and why of this feature

@yesnault
feat (engine,ui): default group & worker model
ae40fc1 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
feat (engine,ui): allow provisioning for restricted wm
60eda09 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
cr
a092caa 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
cr
fd5303a 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@fsamin fsamin merged commit 60c36ef into master Mar 27, 2018
@fsamin fsamin removed the review label Mar 27, 2018
@yesnault yesnault deleted the ye-provision-retricted branch May 10, 2018 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsamin fsamin fsamin approved these changes

@sguiheux sguiheux sguiheux approved these changes

@bnjjj bnjjj bnjjj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yesnault @fsamin @sguiheux @bnjjj