Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove hcl support #2460

Merged
merged 1 commit into from
Mar 26, 2018
Merged

refactor: remove hcl support #2460

merged 1 commit into from
Mar 26, 2018

Conversation

yesnault
Copy link
Member

  1. Description
    No hcl exporter, we keep json and yaml on import / export only

  2. Related issues
    close refactor: delet hcl format -> yml #2312

  3. About tests
    n/a, tests on hcl import removed

  4. Mentions

@ovh/cds

Signed-off-by: Yvonnick Esnault yvonnick.esnault@corp.ovh.com

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
Copy link
Member

@fsamin fsamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have to remove hcl from vendor

@yesnault
Copy link
Member Author

@fsamin dep ensure doesn't want :-D

@yesnault
Copy link
Member Author

@fsamin hum, I'll try to remove it manually, then dep ensure

@yesnault
Copy link
Member Author

yesnault commented Mar 25, 2018

@fsamin I confirm, hcl is a dependency of another dependency (venom), I can't removed it from vendor

@sguiheux sguiheux merged commit 564e191 into master Mar 26, 2018
@sguiheux sguiheux removed the review label Mar 26, 2018
@yesnault yesnault deleted the ye-refactor-#2312 branch May 10, 2018 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: delet hcl format -> yml
4 participants