feat(api): add workflow default tags after add repository webhook #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Coenen <benjamin.coenen@hotmail.com>
fsamin
requested changes
Mar 25, 2018
sguiheux
approved these changes
Mar 26, 2018
…on and repository Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
fsamin
requested changes
Mar 29, 2018
|
|
||
| for _, wf := range workflows { | ||
| tx, errTx := db.Begin() | ||
| if errTx != nil { |
There was a problem hiding this comment.
don't you have to lock the workflow ?
There was a problem hiding this comment.
I only lock the metadata of the workflow
fsamin
approved these changes
Mar 29, 2018
|
|
||
| for _, wf := range workflows { | ||
| tx, errTx := db.Begin() | ||
| if errTx != nil { |
|
tested on preprod with success |
yesnault
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Benjamin Coenen benjamin.coenen@hotmail.com
add workflow default tags after add repository webhook
close Automatic workflow tag #2448
@ovh/cds