feat: add izanami as feature flipping provider #2507
Conversation
engine/api/feature/flipping.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| FeatWorkflowAsCode = "cds:wasc" |
There was a problem hiding this comment.
why public? If public, need some doc
There was a problem hiding this comment.
Public because you will need it on code
sdk/project.go
Outdated
| @@ -31,6 +31,13 @@ type Project struct { | |||
| Keys []ProjectKey `json:"keys" yaml:"keys" db:"-" cli:"-"` | |||
| VCSServers []ProjectVCSServer `json:"vcs_servers" yaml:"vcs_servers" db:"-" cli:"-"` | |||
| Platforms []ProjectPlatform `json:"platforms" yaml:"platforms" db:"-" cli:"-"` | |||
| Features ProjectFeatures `json:"features" yaml:"platforms" db:"-" cli:"-"` | |||
engine/api/api.go
Outdated
| ClientSecret string `toml:"client_secret"` | ||
| Token string `toml;"token" comment:"Token shared between Izanami and CDS to be able to send webhooks from izanami"` | ||
| } | ||
| } |
There was a problem hiding this comment.
missing doc for toml configuration, and toml key name for FeaturesFlipping and Izanami
engine/api/api.go
Outdated
| ClientSecret string `toml:"client_secret"` | ||
| Token string `toml;"token" comment:"Token shared between Izanami and CDS to be able to send webhooks from izanami"` | ||
| } | ||
| } |
engine/api/api.go
Outdated
| @@ -352,6 +361,12 @@ func (a *API) Serve(ctx context.Context) error { | |||
| a.Config.SMTP.TLS, | |||
| a.Config.SMTP.Disable) | |||
|
|
|||
| // Initialize feature package | |||
| log.Info("Initializing feature flipping") | |||
There was a problem hiding this comment.
add the URL in the log (kinda a debug the bug)
engine/api/api.go
Outdated
| // Initialize feature package | ||
| log.Info("Initializing feature flipping") | ||
| if a.Config.FeaturesFlipping.Izanami.ApiURL != "" { | ||
| feature.Init(a.Config.FeaturesFlipping.Izanami.ApiURL, a.Config.FeaturesFlipping.Izanami.ClientID, a.Config.FeaturesFlipping.Izanami.ClientSecret) |
| "github.com/ovh/cds/engine/api/feature" | ||
| ) | ||
|
|
||
| func (api *API) cleanFeatureHandler() Handler { |
There was a problem hiding this comment.
Please add a test (to cover the router)
There was a problem hiding this comment.
it will be overkill no?
|
is it possible to add |
|
@yesnault you can create an issue, but do not block PR for this |
engine/api/api.go
Outdated
| ClientID string `toml:"client_id"` | ||
| ClientSecret string `toml:"client_secret"` | ||
| Token string `toml;"token" comment:"Token shared between Izanami and CDS to be able to send webhooks from izanami"` | ||
| } |
There was a problem hiding this comment.
missing `toml:"izanami" + comment about what is is, why use it, etc... or just 'enable alpha feature, use it with precaution'
There was a problem hiding this comment.
and something under https://ovh.github.io/cds/hosting/ about izanami?
There was a problem hiding this comment.
not for now, it's not mandatory. We also have to discuss about release ;)
engine/api/api.go
Outdated
| @@ -134,7 +134,7 @@ type Configuration struct { | |||
| ClientID string `toml:"client_id"` | |||
| ClientSecret string `toml:"client_secret"` | |||
| Token string `toml;"token" comment:"Token shared between Izanami and CDS to be able to send webhooks from izanami"` | |||
@ovh/cds