Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix sse when 401 occured #3345

Merged
merged 3 commits into from
Sep 21, 2018
Merged

fix(ui): fix sse when 401 occured #3345

merged 3 commits into from
Sep 21, 2018

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Sep 20, 2018

Signed-off-by: Benjamin Coenen benjamin.coenen@corp.ovh.com

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 20, 2018

CDS Report build-ui#6075.0 ✘

  • Compile

    • Build UI ✔
    • TU All -
    • TU model ✔
    • TU service ✘
    • TU shared ✔
    • TU views ✔
      Unit Tests Report
  • HeadlessChrome 0.0.0 (Linux 0.0.0)

  • HeadlessChrome 0.0.0 (Linux 0.0.0).2084459

    • CDS: application Store should update the application ✘

    • CDS: application Store should attach then Detach a repository ✘

    • CDS: project Store should update Project ✘

  • HeadlessChrome 0.0.0 (Linux 0.0.0).2084461

  • HeadlessChrome 0.0.0 (Linux 0.0.0).2084460

Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 21, 2018

CDS Report ut-engine#6082.0 ✘

  • Stage 1

    • Engine Test with DB ✘
      Unit Tests Report
  • github.com/ovh/cds/cli

  • github.com/ovh/cds/engine/api

    • Test_postWorkflowHandlerWithRootShouldSuccess ✘
  • github.com/ovh/cds/engine/api/application

  • github.com/ovh/cds/engine/api/environment

  • github.com/ovh/cds/engine/api/keys

  • github.com/ovh/cds/engine/api/migrate

  • github.com/ovh/cds/engine/api/pipeline

  • github.com/ovh/cds/engine/api/plugin

  • github.com/ovh/cds/engine/api/project

  • github.com/ovh/cds/engine/api/secret

  • github.com/ovh/cds/engine/api/user

  • github.com/ovh/cds/engine/api/warning

  • github.com/ovh/cds/engine/api/worker

  • github.com/ovh/cds/engine/api/workflow

  • github.com/ovh/cds/engine/hatchery/swarm

  • github.com/ovh/cds/engine/hooks

  • github.com/ovh/cds/engine/repositories

  • github.com/ovh/cds/engine/vcs

  • github.com/ovh/cds/engine/vcs/bitbucket

  • github.com/ovh/cds/engine/vcs/github

  • github.com/ovh/cds/engine/vcs/gitlab

  • github.com/ovh/cds/engine/worker

  • github.com/ovh/cds/sdk

  • github.com/ovh/cds/sdk/cdsclient

  • github.com/ovh/cds/sdk/exportentities

  • github.com/ovh/cds/sdk/interpolate

  • github.com/ovh/cds/sdk/luascript

  • github.com/ovh/cds/sdk/namesgenerator

  • github.com/ovh/cds/sdk/plugin/dummy/caller

  • github.com/ovh/cds/sdk/vcs/git

@@ -43,6 +43,7 @@ setInterval(() => {
try {
var xhr = new XMLHttpRequest();
xhr.open('GET', pingUrl , false, null, null);
xhr.setRequestHeader(headerKey, headerValue);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing impact on webWorker.js ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@sguiheux sguiheux merged commit 586dd0e into master Sep 21, 2018
@bnjjj bnjjj deleted the fix_ui_sse branch October 10, 2018 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants