fix: do not allow additionalProperties #4785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sguiheux
requested review from
bnjjj,
fsamin,
richardlt and
yesnault
as code owners
bnjjj
approved these changes
Nov 27, 2019
|
CDS Report cds-package#11487.0 ✘
|
yesnault
approved these changes
Nov 27, 2019
fsamin
approved these changes
Nov 28, 2019
richardlt
requested changes
Dec 2, 2019
| @@ -107,7 +107,7 @@ func toolsYamlSchemaRun(v cli.Values) error { | |||
| results := make([]string, len(types)) | |||
| for i := range types { | |||
| r := jsonschema.Reflector{ | |||
| AllowAdditionalProperties: true, | |||
| AllowAdditionalProperties: false, | |||
There was a problem hiding this comment.
This was useful to ignore error in yaml when a unknown entry is set. This was set to true to ignore error for custom action where custom names are unknown keys in yaml.
There was a problem hiding this comment.
to be able to validate a yaml. To avoid that people enter a key that doesn ’t match the schema.
Today I can type foo: bar in a workflow yaml file, and it’s ok
|
Closed because of #4872 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ovh/cds