feat(sdk): restart goroutines #5821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: francois samin <francois.samin@corp.ovh.com>
yesnault
previously approved these changes
May 19, 2021
|
CDS Report build-all-cds#16031.0 ✘
|
richardlt
requested changes
May 19, 2021
| // GoRoutines contains list of routines that have to stay up | ||
| type GoRoutines struct { | ||
| mutex sync.Mutex | ||
| status map[string]bool | ||
| status []*GoRoutine |
There was a problem hiding this comment.
Should we keep the mutex to protect the status slice ? In case Run is called by multiple routines ?
sdk/goroutine.go
Outdated
| return | ||
| case <-t.C: | ||
| for _, g := range m.status { | ||
| if !g.Active { |
There was a problem hiding this comment.
Suggested change
| if !g.Active { | |
| if !g.Active && g.Restart { |
sguiheux
previously approved these changes
May 20, 2021
|
CDS Report build-all-cds#16043.0 ✘
|
|
CDS Report build-all-cds#16049.0 ✘
|
|
SonarCloud Quality Gate failed. |
richardlt
approved these changes
May 24, 2021
sguiheux
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: francois samin francois.samin@corp.ovh.com