Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not get item from an unsync backend #5836

Merged
merged 5 commits into from Jun 14, 2021
Merged

fix: do not get item from an unsync backend #5836

merged 5 commits into from Jun 14, 2021

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Jun 7, 2021

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@sguiheux sguiheux changed the title fix: do not get item from a unit that can't sync fix: do not send logs into CDS + remove unsync backend from getItem Jun 7, 2021
yesnault
yesnault previously approved these changes Jun 7, 2021
View reviewed changes
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 7, 2021

CDS Report build-all-cds#16107.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✘

fsamin
fsamin previously approved these changes Jun 8, 2021
View reviewed changes
@sguiheux sguiheux dismissed stale reviews from fsamin and yesnault via a29480b June 11, 2021 13:55
@sguiheux sguiheux changed the title fix: do not send logs into CDS + remove unsync backend from getItem fix: do not get item from an unsync backend Jun 11, 2021
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 14, 2021

CDS Report build-all-cds#16137.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 14, 2021

CDS Report build-all-cds#16137.2 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@sguiheux sguiheux merged commit dde3834 into master Jun 14, 2021
@sguiheux sguiheux deleted the DontGetItem branch June 18, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@richardlt richardlt richardlt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt