Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdn): random position #5842

Merged
merged 2 commits into from Jun 11, 2021
Merged

fix(cdn): random position #5842

merged 2 commits into from Jun 11, 2021

Conversation

sguiheux
Copy link
Collaborator

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

fsamin
fsamin previously approved these changes Jun 10, 2021
View reviewed changes
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 10, 2021

CDS Report build-all-cds#16132.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

yesnault
yesnault previously approved these changes Jun 10, 2021
View reviewed changes
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 10, 2021

CDS Report build-all-cds#16132.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
  • Analyse
    • Sonar ✘

@sguiheux sguiheux dismissed stale reviews from yesnault and fsamin via fd66edc June 11, 2021 08:18
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 11, 2021

CDS Report build-all-cds#16133.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✘
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@sonarcloud
Copy link

sonarcloud bot commented Jun 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sguiheux sguiheux merged commit a28bde4 into master Jun 11, 2021
@sguiheux sguiheux deleted the fixUnitTest branch June 18, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault left review comments

@richardlt richardlt Awaiting requested review from richardlt richardlt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sguiheux @ovh-cds @yesnault @fsamin