Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): ternary, urlencode, dirname, basename interpolate helper #6057

Merged
merged 5 commits into from Jan 28, 2022

Conversation

louisquentinjoucla
Copy link
Contributor

  1. Description
    Add more helpers, will be useful for venom
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

sdk/interpolate/interpolate.go Outdated Show resolved Hide resolved
sdk/interpolate/interpolate.go Outdated Show resolved Hide resolved
sdk/interpolate/interpolate_test.go Outdated Show resolved Hide resolved
sdk/interpolate/interpolate_test.go Outdated Show resolved Hide resolved
sdk/interpolate/interpolate_test.go Outdated Show resolved Hide resolved
Signed-off-by: Louis-Quentin <louis-quentin.joucla@corp.ovh.com>
Signed-off-by: Louis-Quentin <louis-quentin.joucla@corp.ovh.com>
This reverts commit d4e0744.

Signed-off-by: Louis-Quentin <louis-quentin.joucla@corp.ovh.com>
Signed-off-by: Louis-Quentin <louis-quentin.joucla@corp.ovh.com>
Copy link
Member

@fsamin fsamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for your PR
LGTM

Signed-off-by: Louis-Quentin <louis-quentin.joucla@corp.ovh.com>
@fsamin fsamin merged commit df7bcf9 into ovh:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants