Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): don't send event to public event integrations #6066

Merged
merged 7 commits into from Jan 24, 2022
Merged

feat(api): don't send event to public event integrations #6066

merged 7 commits into from Jan 24, 2022

Conversation

fsamin
Copy link
Member

@fsamin fsamin commented Jan 18, 2022

Signed-off-by: francois samin francois.samin@corp.ovh.com

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@fsamin
chore(api): don't send event to public event integrations
801419c 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@fsamin
refactor(api): add log info on post /events
e834a00 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@ovh ovh deleted a comment from ovh-cds Jan 20, 2022
@ovh ovh deleted a comment from ovh-cds Jan 20, 2022
@ovh ovh deleted a comment from ovh-cds Jan 20, 2022
@ovh ovh deleted a comment from ovh-cds Jan 20, 2022
yesnault
yesnault requested changes Jan 20, 2022
View reviewed changes
Copy link
Member

@yesnault yesnault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing impact on https://ovh.github.io/cds/docs/integrations/kafka/kafka_events/#create-a-public-kafka-integration-for-whole-cds-projects

@fsamin
fix: public integration is now global
de73b71 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@fsamin fsamin force-pushed the chore_dont_send_event_to_public_integ branch from 9cba726 to de73b71 Compare January 21, 2022 13:34
@fsamin
fix: doc
c720f5c 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@ovh ovh deleted a comment from ovh-cds Jan 21, 2022
@fsamin
fix: it
67430cc 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@fsamin
fix: it
5f077cd 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 21, 2022

CDS Report build-all-cds#17003.0 ■

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ■

1 similar comment
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jan 21, 2022

CDS Report build-all-cds#17003.0 ■

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ■

@fsamin
fix: config mapstructure
bed380b 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

39.5% 39.5% Coverage
0.0% 0.0% Duplication

@fsamin fsamin requested a review from yesnault January 24, 2022 08:06
@fsamin fsamin changed the title chore(api): don't send event to public event integrations feat(api): don't send event to public event integrations Jan 24, 2022
@fsamin fsamin merged commit 008ec54 into master Jan 24, 2022
@richardlt richardlt deleted the chore_dont_send_event_to_public_integ branch February 10, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@sguiheux sguiheux sguiheux approved these changes

@richardlt richardlt richardlt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fsamin @ovh-cds @yesnault @sguiheux @richardlt