Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): try to fix lock between workers and jobs #6689

Merged
merged 2 commits into from Nov 17, 2023
Merged

fix(api): try to fix lock between workers and jobs #6689

merged 2 commits into from Nov 17, 2023

Conversation

fsamin
Copy link
Member

@fsamin fsamin commented Nov 17, 2023

No description provided.

@fsamin
fix(api): try to fix lock between workers and jobs
a576f03 
Signed-off-by: François Samin <francois.samin@ovhcloud.com>
sguiheux
sguiheux reviewed Nov 17, 2023
View reviewed changes
engine/api/workflow_run_craft.go Outdated Show resolved Hide resolved
engine/api/workflow_run_craft.go Outdated Show resolved Hide resolved
engine/api/workflow_run_craft.go Outdated Show resolved Hide resolved
@fsamin
fix: cr
03038a4 
Signed-off-by: François Samin <francois.samin@ovhcloud.com>
@ovh ovh deleted a comment from ovh-cds Nov 17, 2023
@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 17, 2023

CDS Report build-all-cds#19447.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✘

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@fsamin fsamin merged commit e94d2eb into master Nov 17, 2023
4 checks passed
@fsamin fsamin deleted the fix_api_job_worker_deadlock branch November 20, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@sguiheux sguiheux sguiheux approved these changes

@richardlt richardlt richardlt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fsamin @ovh-cds @yesnault @sguiheux @richardlt