Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hatchery): do not add same job into workersStarter #6722

Merged
merged 7 commits into from Dec 7, 2023
Merged

fix(hatchery): do not add same job into workersStarter #6722

merged 7 commits into from Dec 7, 2023

Conversation

yesnault
Copy link
Member

@yesnault yesnault commented Dec 7, 2023

No description provided.

@yesnault
fix(hatchery): do not add same job into workersStarter
c7ed4a5 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault yesnault marked this pull request as draft December 7, 2023 10:25
@ovh-cds
Copy link
Collaborator

ovh-cds commented Dec 7, 2023

CDS Report build-cds#19651.0 ✔

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔

fsamin
fsamin requested changes Dec 7, 2023
View reviewed changes
engine/hatchery/serve.go Outdated Show resolved Hide resolved
engine/hatchery/serve.go Outdated Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented Dec 7, 2023

CDS Report integration-cds#19651.0 ✔

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ✔
    • Standalone Tests v2 ✔

@yesnault
feat: cr
b8b8822 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: cr
37cae4c 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: cr
d46957f 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: cr
974b626 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: cr
be6e949 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault yesnault requested a review from fsamin December 7, 2023 12:21
@yesnault yesnault marked this pull request as ready for review December 7, 2023 12:21
@ovh-cds
Copy link
Collaborator

ovh-cds commented Dec 7, 2023

CDS Report build-cds#19656.0 ✔

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Dec 7, 2023

CDS Report integration-cds#19656.0 ✘

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ✔
    • Standalone Tests v2 ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Dec 7, 2023

CDS Report integration-cds#19656.1 ✔

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ✔
    • Standalone Tests v2 ✔

richardlt
richardlt reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@richardlt richardlt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The map is not updated when receiving events from the websocket.

@yesnault
fix: cr
8922ad1 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
Copy link
Member Author

yesnault commented Dec 7, 2023

The map is not updated when receiving events from the websocket.

fixed

@ovh-cds
Copy link
Collaborator

ovh-cds commented Dec 7, 2023

CDS Report build-cds#19658.0 ✔

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Dec 7, 2023

CDS Report integration-cds#19658.0 ✔

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ✔
    • Standalone Tests v2 ✔

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@yesnault yesnault merged commit a65f819 into master Dec 7, 2023
5 checks passed
@yesnault yesnault deleted the ye-1701938058 branch December 7, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsamin fsamin fsamin approved these changes

@sguiheux sguiheux sguiheux approved these changes

@richardlt richardlt richardlt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yesnault @ovh-cds @fsamin @sguiheux @richardlt