fix (api): all goroutines are managed with context #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sguiheux
requested changes
Jun 6, 2017
engine/api/event/event.go
Outdated
| for { | ||
| e := sdk.Event{} | ||
| cache.Dequeue("events", &e) | ||
| cache.DequeueWithContext(c, "events", &e) | ||
| err := c.Err() |
engine/api/hatchery/heartbeat.go
Outdated
| log.Debug("HatcheryHeartbeat> Hatchery %s removed.\n", w[i].Name) | ||
|
|
||
| for i := range w { | ||
| err = DeleteHatchery(db, w[i].ID, w[i].Model.ID) |
engine/api/hook.go
Outdated
| case <-tick: | ||
| h := hook.ReceivedHook{} | ||
| cache.DequeueWithContext(c, "hook:recovery", &h) | ||
| err := c.Err() |
engine/api/pipeline/awol.go
Outdated
| defer log.Fatalf("Goroutine of pipeline.AWOLPipelineKiller exited - Exit CDS Engine") | ||
|
|
||
| func AWOLPipelineKiller(c context.Context, DBFunc func() *gorp.DbMap) { | ||
| tick := time.NewTicker(5 * time.Minute).C |
engine/api/sessionstore/redis.go
Outdated
| func (s *Redis) vacuumCleaner() { | ||
| log.Info("Redis> Starting Session Vacuum Cleaner") | ||
| func (s *Redis) vacuumCleaner(c context.Context) { | ||
| tick := time.NewTicker(5 * time.Second).C |
engine/api/cache/redis.go
Outdated
| @@ -174,7 +188,7 @@ func (s *RedisStore) DequeueWithContext(c context.Context, queueName string, val | |||
| elemChan := make(chan string) | |||
| var once sync.Once | |||
| go func() { | |||
| ticker := time.NewTicker(50 * time.Millisecond).C | |||
| ticker := time.NewTicker(400 * time.Millisecond).C | |||
| @@ -34,13 +34,12 @@ func (s *InMemory) New(k SessionKey) (SessionKey, error) { | |||
| s.data[k] = cache | |||
| s.lock.Unlock() | |||
|
|
|||
| go func(k SessionKey) { | |||
| time.Sleep(time.Duration(s.ttl) * time.Minute) | |||
| time.AfterFunc(time.Duration(s.ttl)*time.Minute, func() { | |||
| "github.com/ovh/cds/sdk" | ||
| "github.com/ovh/cds/sdk/log" | ||
| ) | ||
|
|
||
| //ModelCapabilititiesCacheLoader set all model Capabilities in the cache | ||
| func ModelCapabilititiesCacheLoader(delay time.Duration) { | ||
| func ModelCapabilititiesCacheLoader(c context.Context, delay time.Duration, DBFunc func() *gorp.DbMap) { | ||
| tick := time.NewTicker(delay).C |
yesnault
requested changes
Jun 6, 2017
| @@ -119,3 +120,10 @@ func DequeueWithContext(c context.Context, queueName string, value interface{}) | |||
| } | |||
| s.DequeueWithContext(c, queueName, value) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
fixed, but comment is on the wrong line
sguiheux
approved these changes
Jun 6, 2017
yesnault
approved these changes
Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.