Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python3 support #4

Merged
merged 4 commits into from
Apr 14, 2020
Merged

Python3 support #4

merged 4 commits into from
Apr 14, 2020

Conversation

brabiega
Copy link
Collaborator

No description provided.

@brabiega brabiega mentioned this pull request Apr 12, 2020
Closed
@brabiega brabiega linked an issue Apr 12, 2020 that may be closed by this pull request
celery-dyrygent appears to only support python 2.x #1
Closed
@brabiega
Copy link
Collaborator Author

There is 1 component test failing due to fix in celery
celery/celery#5613

@brabiega
Copy link
Collaborator Author

Tested with celery 4.4.2
Python 3.6.9
Python 3.8.2
Python 2.7.17
Tests are passing
Also tested manually, tasks are processed by workflow processor

@brabiega brabiega requested a review from sadziu82 April 13, 2020 10:50
@brabiega
Copy link
Collaborator Author

@sadziu82 could you take a look? :)

@sadziu82 sadziu82 merged commit d585065 into master Apr 14, 2020
@kironk
Copy link

kironk commented Apr 15, 2020

Thank you for this. It would be great if you could cut a release with Python 3 support.

@brabiega brabiega linked an issue Apr 18, 2020 that may be closed by this pull request
Release version 0.7.0 #5
Closed
@brabiega brabiega deleted the python3-support branch June 13, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadziu82 sadziu82 sadziu82 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release version 0.7.0 celery-dyrygent appears to only support python 2.x
3 participants
@brabiega @kironk @sadziu82