feat(dedicated): missing guidance to reduce kyc upload issues #11155

MaximeBajeux · 2024-03-12T08:36:58Z

Add custom text to inform individual and corporation indian customers to avoid documents upload issues Ref: MANAGER-13105

Question	Answer
Branch?	`master`
Bug fix?	no
New feature?	yes
Breaking change?	no
Tickets	MANAGER-13105
License	BSD 3-Clause

Try to keep pull requests small so they can be easily reviewed.
Commits are signed-off
Only FR translations have been updated
Branch is up-to-date with target branch
Lint has passed locally
Standalone app was ran and tested locally
Ticket reference is mentioned in linked commits (internal only)
Breaking change is mentioned in relevant commits (n/a)

Description

I created two components to display conditionally more informations about kyc documents to upload for individual and corporation Indian customers

+  "user_account_identity_documents_corporation_requirements": "Vérification des documents nécessaire",
+  "user_account_identity_documents_corporation_requirements_intro": "Vous avez créé un compte. Pour réaliser une commande sur notre site internet, des vérifications sont nécessaires en conformité avec la législation indienne. Téléchargez vos documents",
+  "user_account_identity_documents_corporation_requirements_identity": "Preuve d'identité : ",
+  "user_account_identity_documents_corporation_requirements_identity_list": "Carte d'identité, passeport, permis de conduire, carte d’électeur, carte Adhaar ou la preuve de possession du numéro Aadhaar du représentant légal, directeur des opérations ou tout contact mentionné dans le GST.",


Suggested change

"user_account_identity_documents_corporation_requirements_identity_list": "Carte d'identité, passeport, permis de conduire, carte d’électeur, carte Adhaar ou la preuve de possession du numéro Aadhaar du représentant légal, directeur des opérations ou tout contact mentionné dans le GST.",

"user_account_identity_documents_corporation_requirements_identity_list": "Carte d'identité, passeport, permis de conduire, carte d'électeur, carte Adhaar ou la preuve de possession du numéro Aadhaar du représentant légal, directeur des opérations ou tout contact mentionné dans le GST.",

anooparveti · 2024-03-18T07:46:17Z

...lient/app/account/identity-documents/components/identity-documents-corporation/template.html

+    <li>
+        <span data-translate="user_account_identity_documents_corporation_requirements_identity_acceptance_criteria_1"></span>
+    </li>
+    <li>
+        <span data-translate="user_account_identity_documents_corporation_requirements_identity_acceptance_criteria_2"></span>
+    </li>
+    <li>
+        <span data-translate="user_account_identity_documents_corporation_requirements_identity_acceptance_criteria_3"></span>
+    </li>
+    <li>
+        <span data-translate="user_account_identity_documents_corporation_requirements_identity_acceptance_criteria_4"></span>
+    </li>


nitpick: Content can be directly included in the li and span can be avoided.

Suggested change

<li>



</li>

<li>



</li>

<li>



</li>

<li>



</li>

<li data-translate="user_account_identity_documents_corporation_requirements_identity_acceptance_criteria_1">

</li>

<li data-translate="user_account_identity_documents_corporation_requirements_identity_acceptance_criteria_2">

</li>

<li data-translate="user_account_identity_documents_corporation_requirements_identity_acceptance_criteria_3">

</li>

<li data-translate="user_account_identity_documents_corporation_requirements_identity_acceptance_criteria_4">

</li>

anooparveti · 2024-03-18T07:46:53Z

...lient/app/account/identity-documents/components/identity-documents-corporation/template.html

+    <li>
+        <span data-translate="user_account_identity_documents_corporation_requirements_sworn_statement_acceptance_criteria_1"></span>
+    </li>


Same as https://github.com/ovh/manager/pull/11155/files#r1528002398

anooparveti · 2024-03-18T07:47:15Z

...lient/app/account/identity-documents/components/identity-documents-corporation/template.html

+    <li>
+        <span data-translate="user_account_identity_documents_corporation_requirements_address_acceptance_criteria_1"></span>
+    </li>
+    <li>
+        <span data-translate="user_account_identity_documents_corporation_requirements_address_acceptance_criteria_2"></span>
+    </li>
+    <li>
+        <span data-translate="user_account_identity_documents_corporation_requirements_address_acceptance_criteria_3"></span>
+    </li>


Same as https://github.com/ovh/manager/pull/11155/files#r1528002398

anooparveti · 2024-03-18T07:47:32Z

...lient/app/account/identity-documents/components/identity-documents-corporation/template.html

+    <li>
+        <span data-translate="user_account_identity_documents_corporation_requirements_tva_acceptance_criteria_1"></span>
+    </li>
+    <li>
+        <span data-translate="user_account_identity_documents_corporation_requirements_tva_acceptance_criteria_2"></span>
+    </li>
+    <li>
+        <span data-translate="user_account_identity_documents_corporation_requirements_tva_acceptance_criteria_3"></span>
+    </li>


Same as https://github.com/ovh/manager/pull/11155/files#r1528002398

anooparveti · 2024-03-18T07:48:08Z

...ated/client/app/account/identity-documents/components/identity-documents-individual/index.js

+import component from './component';
+
+const moduleName =
+  'ovhManagerDedicatedAccountUserUploadIdentityDocumentsIndRequirements';


Suggested change

'ovhManagerDedicatedAccountUserUploadIdentityDocumentsIndRequirements';

'ovhManagerDedicatedAccountUserUploadIdentityDocumentsIndividualRequirements';

anooparveti · 2024-03-18T07:48:21Z

...ted/client/app/account/identity-documents/components/identity-documents-corporation/index.js

+import component from './component';
+
+const moduleName =
+  'ovhManagerDedicatedAccountUserUploadIdentityDocumentsCorpRequirements';


Suggested change

'ovhManagerDedicatedAccountUserUploadIdentityDocumentsCorpRequirements';

'ovhManagerDedicatedAccountUserUploadIdentityDocumentsCorporationRequirements';

anooparveti · 2024-03-18T08:39:10Z

...client/app/account/identity-documents/components/identity-documents-individual/template.html

+    <li>
+        <span data-translate="user_account_identity_documents_individual_requirements_identity_acceptance_criteria_1"></span>
+    </li>
+    <li>
+        <span data-translate="user_account_identity_documents_individual_requirements_identity_acceptance_criteria_2"></span>
+    </li>
+    <li>
+        <span data-translate="user_account_identity_documents_individual_requirements_identity_acceptance_criteria_3"></span>
+    </li>
+    <li>
+        <span data-translate="user_account_identity_documents_individual_requirements_identity_acceptance_criteria_4"></span>
+    </li>
+    <li>
+        <span data-translate="user_account_identity_documents_individual_requirements_identity_acceptance_criteria_5"></span>
+    </li>


Same as #11155 (comment)

anooparveti · 2024-03-18T08:39:22Z

...client/app/account/identity-documents/components/identity-documents-individual/template.html

+    <li>
+       <span data-translate="user_account_identity_documents_individual_requirements_address_acceptance_criteria_1"></span>
+    </li>
+    <li>
+       <span data-translate="user_account_identity_documents_individual_requirements_address_acceptance_criteria_2"></span>
+    </li>


Same as #11155 (comment)

anooparveti · 2024-03-18T08:40:54Z

...ated/client/app/account/identity-documents/components/identity-documents-individual/index.js

+
+angular
+  .module(moduleName, ['pascalprecht.translate'])
+  .component('uploadIdentityDocumentsIndRequirements', component)


Suggested change

.component('uploadIdentityDocumentsIndRequirements', component)

.component('AccountUploadIdentityDocumentsIndividualRequirements', component)

anooparveti · 2024-03-18T08:41:12Z

...ted/client/app/account/identity-documents/components/identity-documents-corporation/index.js

+
+angular
+  .module(moduleName, ['pascalprecht.translate'])
+  .component('uploadIdentityDocumentsCorpRequirements', component)


Suggested change

.component('uploadIdentityDocumentsCorpRequirements', component)

.component('accountUploadIdentityDocumentsCorporationRequirements', component)

sonarcloud · 2024-03-27T16:02:53Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

qpavy · 2024-03-29T13:25:17Z

...es/manager/apps/dedicated/client/app/account/identity-documents/user-identity-documents.html

+        data-ng-if="$ctrl.user_type == $ctrl.USER_TYPE.individual"
+    ></account-upload-identity-documents-individual-requirements>
+    <div
+        data-ng-if="$ctrl.user_type != $ctrl.USER_TYPE.corporation && $ctrl.user_type != $ctrl.USER_TYPE.individual"


Suggested change

data-ng-if="$ctrl.user_type != $ctrl.USER_TYPE.corporation && $ctrl.user_type != $ctrl.USER_TYPE.individual"

data-ng-if="![$ctrl.USER_TYPE.corporation,$ctrl.USER_TYPE.individual].includes($ctrl.user_type)"

Add text to add more context for corporation and individual ref: MANAGER-13105 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>

Change quote in translation ref: MANAGER-13105 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>

Add change requests to follow the guidelines ref: MANAGER-13105 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>

Remove non necessary span ref: feat/MANAGER-13105 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>

Refacto translations to avoid duplicates ref: MANAGER-13105s Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>

… BATCH 2 (#11383) refacto the component to include association and others ref: MANAGER-14056 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com> Co-authored-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>

Signed-off-by: CDS Translator Agent <opensource@ovh.net>

fix error on Aadhaar syntax ref: MANAGER-13105 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>

sonarcloud · 2024-05-21T07:17:33Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

MaximeBajeux requested a review from a team as a code owner March 12, 2024 08:36

MaximeBajeux requested review from qpavy, anooparveti and ghyenne March 12, 2024 08:36

github-actions bot added universe-bare-metal-cloud translation required feature New feature labels Mar 12, 2024

dectotam requested changes Mar 12, 2024

View reviewed changes

MaximeBajeux force-pushed the feat/MANAGER-13105 branch from 6d75817 to 38ee18b Compare March 13, 2024 08:49

MaximeBajeux requested a review from dectotam March 13, 2024 09:58

MaximeBajeux force-pushed the feat/MANAGER-13105 branch from 38ee18b to c7f7373 Compare March 14, 2024 09:24

dectotam requested changes Mar 15, 2024

View reviewed changes

MaximeBajeux requested a review from dectotam March 15, 2024 14:16

benjaminlepine previously approved these changes Mar 15, 2024

View reviewed changes

anooparveti reviewed Mar 18, 2024

View reviewed changes

anooparveti requested changes Mar 18, 2024

View reviewed changes

anooparveti reviewed Mar 18, 2024

View reviewed changes

anooparveti requested changes Mar 18, 2024

View reviewed changes

MaximeBajeux dismissed benjaminlepine’s stale review via 47540ec March 18, 2024 08:54

MaximeBajeux requested a review from anooparveti March 18, 2024 09:23

github-actions bot added the has conflicts Has conflicts to resolve before merging label Mar 18, 2024

benjaminlepine previously approved these changes Mar 18, 2024

View reviewed changes

MaximeBajeux dismissed benjaminlepine’s stale review via ccb0ff9 March 19, 2024 08:57

MaximeBajeux force-pushed the feat/MANAGER-13105 branch from 5508564 to ccb0ff9 Compare March 19, 2024 08:57

github-actions bot removed the has conflicts Has conflicts to resolve before merging label Mar 19, 2024

dectotam previously approved these changes Mar 19, 2024

View reviewed changes

MaximeBajeux requested a review from JacquesLarique March 27, 2024 16:02

qpavy previously approved these changes Mar 29, 2024

View reviewed changes

anooparveti previously approved these changes Apr 16, 2024

View reviewed changes

MaximeBajeux dismissed stale reviews from anooparveti and qpavy via 91600bf May 2, 2024 08:36

github-actions bot added the has conflicts Has conflicts to resolve before merging label May 2, 2024

Maxime Bajeux and others added 8 commits May 21, 2024 09:08

feat(dedicated.account): missing guidance to reduce kyc upload issues

b57e4d4

Add text to add more context for corporation and individual ref: MANAGER-13105 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>

feat(dedicated.account): missing guidance to reduce kyc upload issues

d6a9283

Change quote in translation ref: MANAGER-13105 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>

feat(dedicated.account): missing guidance to reduce kyc upload issues

5d2015e

Add change requests to follow the guidelines ref: MANAGER-13105 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>

feat(dedicated.account): missing guidance to reduce kyc upload issues

0f2ef09

Add change requests to follow the guidelines ref: MANAGER-13105 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>

feat(dedicated.account): missing guidance to reduce kyc upload issues

4cbfc1e

Remove non necessary span ref: feat/MANAGER-13105 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>

feat(dedicated): missing guidance to reduce kyc upload issue

4934ffb

Refacto translations to avoid duplicates ref: MANAGER-13105s Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>

fix(i18n): add missing translations [CDS 3008]

8f484aa

Signed-off-by: CDS Translator Agent <opensource@ovh.net>

MaximeBajeux force-pushed the feat/MANAGER-13105 branch from 367e9b8 to 8f484aa Compare May 21, 2024 07:11

github-actions bot removed the has conflicts Has conflicts to resolve before merging label May 21, 2024

feat(account.documents): missing guidance to upload kyc

1aadf58

fix error on Aadhaar syntax ref: MANAGER-13105 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>

dectotam approved these changes May 21, 2024

View reviewed changes

darsene approved these changes May 21, 2024

View reviewed changes

antonymarion approved these changes May 21, 2024

View reviewed changes

oalkabouss approved these changes May 21, 2024

View reviewed changes

JacquesLarique approved these changes May 23, 2024

View reviewed changes

MaximeBajeux added quality check: ok and removed translation required labels May 23, 2024

ghyenne changed the base branch from master to release/components-w22 May 23, 2024 15:51

ghyenne merged commit 759a310 into release/components-w22 May 23, 2024
12 of 15 checks passed

ghyenne deleted the feat/MANAGER-13105 branch May 23, 2024 15:53

ghyenne mentioned this pull request May 23, 2024

New release - release/components-w22 #11799

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dedicated): missing guidance to reduce kyc upload issues #11155

feat(dedicated): missing guidance to reduce kyc upload issues #11155

MaximeBajeux commented Mar 12, 2024 •

edited

Loading

dectotam Mar 15, 2024

anooparveti Mar 18, 2024

anooparveti Mar 18, 2024

anooparveti Mar 18, 2024

anooparveti Mar 18, 2024

anooparveti Mar 18, 2024

anooparveti Mar 18, 2024

anooparveti Mar 18, 2024

anooparveti Mar 18, 2024

anooparveti Mar 18, 2024

anooparveti Mar 18, 2024

sonarcloud bot commented Mar 27, 2024

qpavy Mar 29, 2024

sonarcloud bot commented May 21, 2024

	"user_account_identity_documents_corporation_requirements_identity_list": "Carte d'identité, passeport, permis de conduire, carte d’électeur, carte Adhaar ou la preuve de possession du numéro Aadhaar du représentant légal, directeur des opérations ou tout contact mentionné dans le GST.",
	"user_account_identity_documents_corporation_requirements_identity_list": "Carte d'identité, passeport, permis de conduire, carte d'électeur, carte Adhaar ou la preuve de possession du numéro Aadhaar du représentant légal, directeur des opérations ou tout contact mentionné dans le GST.",

	'ovhManagerDedicatedAccountUserUploadIdentityDocumentsIndRequirements';
	'ovhManagerDedicatedAccountUserUploadIdentityDocumentsIndividualRequirements';

	.component('uploadIdentityDocumentsIndRequirements', component)
	.component('AccountUploadIdentityDocumentsIndividualRequirements', component)

	.component('uploadIdentityDocumentsCorpRequirements', component)
	.component('accountUploadIdentityDocumentsCorporationRequirements', component)

	data-ng-if="$ctrl.user_type != $ctrl.USER_TYPE.corporation && $ctrl.user_type != $ctrl.USER_TYPE.individual"
	data-ng-if="![$ctrl.USER_TYPE.corporation,$ctrl.USER_TYPE.individual].includes($ctrl.user_type)"

feat(dedicated): missing guidance to reduce kyc upload issues #11155

feat(dedicated): missing guidance to reduce kyc upload issues #11155

Conversation

MaximeBajeux commented Mar 12, 2024 • edited Loading

Description

Related

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarcloud bot commented Mar 27, 2024

Quality Gate passed

Choose a reason for hiding this comment

sonarcloud bot commented May 21, 2024

Quality Gate passed

MaximeBajeux commented Mar 12, 2024 •

edited

Loading