Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rancher): disable refetch pooling on create page #11361

Merged
merged 2 commits into from
May 20, 2024
Merged

fix(rancher): disable refetch pooling on create page #11361

merged 2 commits into from
May 20, 2024

Conversation

lionel95200x
Copy link
Contributor

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? yes/no
Tickets Fix #MANAGER-14087
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Disable hook that refetch rancher on Create Page

Related

@lionel95200x lionel95200x requested review from a team as code owners April 3, 2024 14:27
@github-actions github-actions bot added feature New feature has conflicts Has conflicts to resolve before merging labels Apr 3, 2024
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14087-move-refetch-hook-in-listing-page branch from 370e6d8 to af8c51a Compare April 8, 2024 09:26
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Apr 8, 2024
vovh
vovh previously approved these changes Apr 9, 2024
View reviewed changes
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14087-move-refetch-hook-in-listing-page branch from af8c51a to 1c7f295 Compare April 10, 2024 14:19
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14087-move-refetch-hook-in-listing-page branch from fc9cf06 to 9158457 Compare April 17, 2024 12:23
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

anooparveti
anooparveti previously approved these changes Apr 17, 2024
View reviewed changes
vovh
vovh previously approved these changes May 17, 2024
View reviewed changes
@anooparveti anooparveti changed the base branch from master to develop May 20, 2024 09:52
@anooparveti anooparveti dismissed stale reviews from vovh and themself May 20, 2024 09:52

The base branch was changed.

anooparveti
anooparveti previously approved these changes May 20, 2024
View reviewed changes
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14087-move-refetch-hook-in-listing-page branch from 9158457 to f3105a4 Compare May 20, 2024 10:49
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14087-move-refetch-hook-in-listing-page branch from f3105a4 to 9753bf3 Compare May 20, 2024 10:51
@lionel95200x
fix: unit test
9b082b8 
Signed-off-by: Lio <lionel95200@gmail.com>
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14087-move-refetch-hook-in-listing-page branch from 9753bf3 to 9b082b8 Compare May 20, 2024 12:05
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@anooparveti anooparveti merged commit d414f36 into develop May 20, 2024
15 checks passed
@anooparveti anooparveti deleted the feat/MANAGER-14087-move-refetch-hook-in-listing-page branch May 20, 2024 15:42
@ghyenne ghyenne mentioned this pull request May 23, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anooparveti anooparveti anooparveti approved these changes

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud aboungnaseng-ovhcloud approved these changes

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@vovh vovh Awaiting requested review from vovh

Assignees
No one assigned
Labels
feature New feature quality check: ok universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lionel95200x @anooparveti @frenautvh @aboungnaseng-ovhcloud @vovh