Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SerialOverLan - Replace SSH keys dropdown by SSH key textarea #11394

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

SerialOverLan - Replace SSH keys dropdown by SSH key textarea #11394

wants to merge 2 commits into from

Conversation

JayBeeDe
Copy link
Member

@JayBeeDe JayBeeDe commented Apr 5, 2024 •
edited

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
    Breaking change is mentioned in relevant commits

Description

Remove API call /me/sshKey dependency for SerialOverLan feature
SSH key-based authentication is still possible for SerialOverLan but specifying the public SSH key directly in a textarea
Opportunity and necessity to make a little visual refacto of the IPMI page

Related

ref: MANAGER-12570

@JayBeeDe JayBeeDe requested a review from a team as a code owner April 5, 2024 15:09
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

qpavy
qpavy previously approved these changes Apr 16, 2024
View reviewed changes
sachinrameshn
sachinrameshn previously approved these changes Apr 17, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed.

@github-actions github-actions bot added the stale No activity since a long time label May 18, 2024
@Dampen59 Dampen59 dismissed stale reviews from sachinrameshn and qpavy via c714143 May 20, 2024 13:10
@Dampen59 Dampen59 force-pushed the feat/MANAGER-12570 branch 2 times, most recently from cab8f82 to 1da5eda Compare May 20, 2024 13:36
@github-actions github-actions bot removed the stale No activity since a long time label May 21, 2024
@JayBeeDe JayBeeDe requested review from a team as code owners May 22, 2024 08:51
@JayBeeDe JayBeeDe requested review from sidlynx and kqesar May 22, 2024 08:51
@JayBeeDe JayBeeDe changed the base branch from master to develop May 22, 2024 08:51
@JayBeeDe
Copy link
Member Author

While opening the SoL session, customer has the message "La connexion au module IPMI en ssh est prête.", but SSH URL to connect to is no longer displayed. Customer has no way to know how to connect to SoL...

The following URL is no longer displayed
image

@Dampen59
Copy link
Contributor

While opening the SoL session, customer has the message "La connexion au module IPMI en ssh est prête.", but SSH URL to connect to is no longer displayed. Customer has no way to know how to connect to SoL...

The following URL is no longer displayed image

Fixed by re-implementing the oui-clipboard element
image

qpavy
qpavy previously approved these changes May 24, 2024
View reviewed changes
@JayBeeDe
feat(dedicated): reorganise IPMI page
68555f5 
Signed-off-by: Jean-Baptiste Delon <jean-baptiste.delon@ovhcloud.com>
@JayBeeDe
feat(dedicated): sol with public sshkey textarea
e470a3d 
ref: MANAGER-12570
Signed-off-by: Jean-Baptiste Delon <jean-baptiste.delon@ovhcloud.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dampen59 Dampen59 Dampen59 left review comments

@qpavy qpavy qpavy approved these changes

@sachinrameshn sachinrameshn sachinrameshn approved these changes

@dectotam dectotam Awaiting requested review from dectotam dectotam is a code owner automatically assigned from ovh/team-manager-dev

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien is a code owner automatically assigned from ovh/team-manager-dev

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JayBeeDe @Dampen59 @qpavy @sachinrameshn