Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(catalog): migrate e2e tests to BDD tests #11515

Merged
merged 1 commit into from
May 23, 2024
Merged

fix(catalog): migrate e2e tests to BDD tests #11515

merged 1 commit into from
May 23, 2024

Conversation

chipp972
Copy link
Contributor

ref: MANAGER-14240

Question Answer
Branch? develop
Bug fix? yes
New feature? no
Breaking change? no
Tickets MANAGER-14240 #...
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@chipp972 chipp972 requested review from a team as code owners April 22, 2024 16:02
@chipp972 chipp972 requested review from sidlynx, seven-amid, dectotam, oalkabouss and ghyenne and removed request for a team April 22, 2024 16:02
@github-actions github-actions bot added build Changes that affect the build system or external dependencie feature New feature labels Apr 22, 2024
@chipp972 chipp972 requested a review from a team as a code owner April 22, 2024 16:11
@chipp972 chipp972 requested review from antleblanc and fchabrolle and removed request for a team April 22, 2024 16:11
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Apr 22, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Apr 22, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Apr 22, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Apr 22, 2024
Base automatically changed from feat/vrack-services-13542 to release/components-w19 May 2, 2024 08:53
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label May 2, 2024
@chipp972 chipp972 force-pushed the feat/catalog-14240 branch 3 times, most recently from 4c04d6f to c8392d7 Compare May 10, 2024 14:05
vovh
vovh previously approved these changes May 13, 2024
View reviewed changes
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label May 13, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label May 13, 2024
vovh
vovh previously approved these changes May 17, 2024
View reviewed changes
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label May 21, 2024
@chipp972 chipp972 dismissed stale reviews from vovh and aboungnaseng-ovhcloud via af9d7ae May 21, 2024 10:29
@github-actions github-actions bot added enabler has conflicts Has conflicts to resolve before merging and removed has conflicts Has conflicts to resolve before merging labels May 21, 2024
fix(catalog): migrate e2e tests to BDD tests
f0dd0f3 
ref: MANAGER-14240

Signed-off-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label May 23, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ghyenne ghyenne changed the base branch from develop to release/components-w22 May 23, 2024 15:36
@ghyenne ghyenne merged commit f5bf926 into release/components-w22 May 23, 2024
15 checks passed
@ghyenne ghyenne deleted the feat/catalog-14240 branch May 23, 2024 15:36
@ghyenne ghyenne mentioned this pull request May 23, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghyenne ghyenne ghyenne approved these changes

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud aboungnaseng-ovhcloud approved these changes

@vovh vovh vovh left review comments

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

@dectotam dectotam Awaiting requested review from dectotam dectotam was automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
build Changes that affect the build system or external dependencie enabler feature New feature quality check: ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chipp972 @ghyenne @aboungnaseng-ovhcloud @vovh