Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/manager 13826 KMS Onboarding #11555

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

vovh
Copy link
Contributor

@vovh vovh commented Apr 24, 2024

Question Answer
Branch? feat/key-management-service
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #13826
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

When a user want to create a first KMS, the onboarding page is available only if no KMS exists

When I go to the manager, the menu display an entry to load the KMS onboarding page.

Related

@vovh vovh changed the title Feat/manager 13826 Feat/manager 13826 KMS Onboarding Apr 26, 2024
@vovh vovh force-pushed the feat/MANAGER-13826 branch 2 times, most recently from 8596575 to b81312c Compare April 26, 2024 07:57
@vovh vovh marked this pull request as ready for review April 29, 2024 07:31
@vovh vovh requested review from a team as code owners April 29, 2024 07:31
@vovh vovh requested review from kqesar, seven-amid, qpavy, MaximeBajeux and darsene and removed request for a team April 29, 2024 07:31
@vovh vovh changed the base branch from feat/key-management-service to feat/MANAGER-13566 April 29, 2024 13:42
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Apr 29, 2024
@vovh vovh force-pushed the feat/MANAGER-13826 branch 2 times, most recently from fe41daf to aa4c635 Compare April 29, 2024 14:18
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Apr 29, 2024
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Apr 30, 2024
@vovh vovh force-pushed the feat/MANAGER-13566 branch 2 times, most recently from ca89813 to 5004753 Compare April 30, 2024 08:34
Base automatically changed from feat/MANAGER-13566 to feat/key-management-service April 30, 2024 08:47
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Apr 30, 2024
ref: MANAGER-13826

Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
@vovh vovh self-assigned this Apr 30, 2024
@vovh vovh merged commit 1c56612 into feat/key-management-service Apr 30, 2024
12 of 13 checks passed
@vovh vovh deleted the feat/MANAGER-13826 branch April 30, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants