Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vrack-services): fix error message not disappearing on overview page #11561

Merged
merged 1 commit into from
May 10, 2024
Merged

fix(vrack-services): fix error message not disappearing on overview page #11561

merged 1 commit into from
May 10, 2024

Conversation

chipp972
Copy link
Contributor

@chipp972 chipp972 commented Apr 25, 2024 •
edited

ref: MANAGER-14189

Question Answer
Branch? develop
Bug fix? yes
New feature? no
Breaking change? no
Tickets MANAGER-14189
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@chipp972 chipp972 requested a review from a team as a code owner April 25, 2024 09:22
@github-actions github-actions bot added the feature New feature label Apr 25, 2024
fix(vrack-services): fix error message not disappearing on overview page
940674a 
ref: MANAGER-14189

Signed-off-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mhelhali-soufien mhelhali-soufien changed the base branch from develop to release/component-w20 May 10, 2024 08:57
@anooparveti anooparveti merged commit 50dbdc6 into release/component-w20 May 10, 2024
14 of 15 checks passed
@anooparveti anooparveti deleted the feat/vrack-services-14189 branch May 10, 2024 09:07
@anooparveti anooparveti mentioned this pull request May 10, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qpavy qpavy qpavy approved these changes

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud aboungnaseng-ovhcloud approved these changes

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion was automatically assigned from ovh/team-manager-dev-angularjs

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux was automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature quality check: ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chipp972 @qpavy @aboungnaseng-ovhcloud @anooparveti