feat(key-management-service): add kms termination #11800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darsene
requested review from
kqesar,
frenautvh,
antonymarion,
sachinrameshn and
JacquesLarique
and removed request for
a team
github-actions
bot
added
translation required
container
manager-components
enabler
feature
darsene
force-pushed
the
feat/MANAGER-13980
branch
from
0b35d3d
to
a686885
Compare
qpavy
reviewed
May 24, 2024
...agement-service/src/public/translations/key-management-service/terminate/Messages_fr_FR.json
Show resolved
Hide resolved
packages/manager/apps/key-management-service/src/components/menu/KmsActionMenu.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/key-management-service/src/pages/listing/TerminateKms.tsx
Show resolved
Hide resolved
qpavy
approved these changes
May 24, 2024
qpavy
reviewed
May 24, 2024
packages/manager-components/src/components/navigation/menus/action/action.component.tsx
Outdated
Show resolved
Hide resolved
darsene
force-pushed
the
feat/key-management-service
branch
from
21a156f
to
78353c5
Compare
github-actions
bot
added
the
has conflicts
darsene
force-pushed
the
feat/MANAGER-13980
branch
from
a686885
to
701b5c1
Compare
github-actions
bot
removed
the
has conflicts
darsene
force-pushed
the
feat/MANAGER-13980
branch
from
701b5c1
to
bc83a95
Compare
darsene
force-pushed
the
feat/MANAGER-13980
branch
from
bc83a95
to
4024c23
Compare
github-actions
bot
added
the
has conflicts
darsene
force-pushed
the
feat/MANAGER-13980
branch
from
4024c23
to
b794759
Compare
github-actions
bot
removed
the
has conflicts
qpavy
approved these changes
May 29, 2024
darsene
force-pushed
the
feat/key-management-service
branch
from
ff4077c
to
17cf3b7
Compare
github-actions
bot
added
the
has conflicts
ref: MANAGER-13980 Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
darsene
force-pushed
the
feat/MANAGER-13980
branch
from
b794759
to
bd9ecb8
Compare
github-actions
bot
removed
manager-components
has conflicts
|
vovh
approved these changes
May 31, 2024
packages/manager/apps/key-management-service/src/api/hooks/useTerminateOKms.ts
Show resolved
Hide resolved
aboungnaseng-ovhcloud
approved these changes
May 31, 2024
vovh
pushed a commit
that referenced
this pull request
Jun 12, 2024
ref: MANAGER-13980 Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
vovh
pushed a commit
that referenced
this pull request
Jun 19, 2024
ref: MANAGER-13980 Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: MANAGER-13980
key-management-serviceDescription
Related