Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager-components): add load more button in datagrid #11851

Closed
wants to merge 7 commits into from
Closed

feat(manager-components): add load more button in datagrid #11851

wants to merge 7 commits into from

Conversation

aboungnaseng-ovhcloud
Copy link
Contributor

Question Answer
Branch? develop
Bug fix? no
New feature? yes/no
Breaking change? yes
Tickets Fix MANAGER-13931
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@aboungnaseng-ovhcloud
feat(a-vrack-test): add vrack services project with new datagrid
a2e1618 
ref: MANAGER-13931

Signed-off-by: Alex Boungnaseng <alex.boungnaseng.ext@corp.ovh.com>
@aboungnaseng-ovhcloud
feat(*): update datagrid and core
e9ab9c2 
ref: MANAGER-13931

Signed-off-by: Alex Boungnaseng <alex.boungnaseng.ext@corp.ovh.com>
@aboungnaseng-ovhcloud
feat(*): move datagrid iceberg hook in manager components
161bf9c 
ref: MANAGER-13931

Signed-off-by: Alex Boungnaseng <alex.boungnaseng.ext@corp.ovh.com>
@aboungnaseng-ovhcloud
feat(pci-users): update datagrid pagination
26738cc 
ref: MANAGER-12931

Signed-off-by: Alex Boungnaseng <alex.boungnaseng.ext@corp.ovh.com>
@aboungnaseng-ovhcloud
feat(datagrid): test datagrid
5d0dea6 
ref: MANAGER-12931

Signed-off-by: Alex Boungnaseng <alex.boungnaseng.ext@corp.ovh.com>
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jun 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
@tanstack/react-table UPDATED 8.11.8 8.17.3
@tanstack/table-core UPDATED 8.11.8 8.17.3
react-i18next UPDATED 14.0.5 14.1.2

@aboungnaseng-ovhcloud
fix(manager-components): datagrid add sort in v2 and V6
2d756eb 
ref: MANAGER-13931

Signed-off-by: Alex Boungnaseng <alex.boungnaseng.ext@corp.ovh.com>
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jun 17, 2024
@aboungnaseng-ovhcloud aboungnaseng-ovhcloud force-pushed the feat/MANAGER-13931-hooks branch 4 times, most recently from fb69ad9 to 6604cff Compare June 25, 2024 15:51
@aboungnaseng-ovhcloud
feat(manager-components): update datagrid v6 without iceberg
2d1863e 
ref: MANAGER-13931

Signed-off-by: Alex Boungnaseng <alex.boungnaseng.ext@corp.ovh.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
24.7% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file feature New feature has conflicts Has conflicts to resolve before merging manager-components translation required universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@aboungnaseng-ovhcloud