Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(telecom-dashboard): add ftth eligibilities list #11855

Merged
merged 2 commits into from
Jun 27, 2024
Merged

feat(telecom-dashboard): add ftth eligibilities list #11855

merged 2 commits into from
Jun 27, 2024

Conversation

Steffy29
Copy link
Contributor

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #UXCT-549
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Add FTTH eligibilities list

Related

@Steffy29 Steffy29 self-assigned this May 31, 2024
@Steffy29 Steffy29 requested a review from a team as a code owner May 31, 2024 12:16
@Steffy29 Steffy29 force-pushed the UXCT-549-internet-access-ftth-eligibility-view branch from 8e38433 to b18e30a Compare May 31, 2024 12:44
@Steffy29 Steffy29 force-pushed the UXCT-549-internet-access-ftth-eligibility-view branch from b18e30a to 678cac3 Compare May 31, 2024 14:22
@Steffy29 Steffy29 force-pushed the UXCT-549-internet-access-ftth-eligibility-view branch from 678cac3 to 6fba353 Compare May 31, 2024 15:59
@Steffy29 Steffy29 force-pushed the UXCT-549-internet-access-ftth-eligibility-view branch from 6fba353 to caad2c7 Compare June 4, 2024 08:45
@Steffy29 Steffy29 requested a review from stif59100 June 4, 2024 12:28
antonymarion
antonymarion previously approved these changes Jun 5, 2024
View reviewed changes
ghyenne
ghyenne previously requested changes Jun 5, 2024
View reviewed changes
packages/manager/apps/telecom/src/app/telecom/pack/access-list/xdsl-access-list.controller.js Outdated Show resolved Hide resolved
packages/manager/apps/telecom/src/app/telecom/pack/access-list/xdsl-access-list.controller.js Outdated Show resolved Hide resolved
packages/manager/apps/telecom/src/app/telecom/pack/access-list/xdsl-access-list.controller.js Outdated Show resolved Hide resolved
packages/manager/apps/telecom/src/app/telecom/pack/access-list/xdsl-access-list.controller.js Outdated Show resolved Hide resolved
packages/manager/apps/telecom/src/app/telecom/pack/access-list/xdsl-access-list.html Outdated Show resolved Hide resolved
packages/manager/apps/telecom/src/app/telecom/pack/access-list/xdsl-access-list.html Outdated Show resolved Hide resolved
packages/manager/apps/telecom/src/app/telecom/pack/access-list/xdsl-access-list.html Outdated Show resolved Hide resolved
packages/manager/apps/telecom/src/app/telecom/pack/access-list/xdsl-access-list.html Outdated Show resolved Hide resolved
packages/manager/apps/telecom/src/app/telecom/pack/access-list/xdsl-access-list.html Outdated Show resolved Hide resolved
@Steffy29 Steffy29 force-pushed the UXCT-549-internet-access-ftth-eligibility-view branch from 1e49aa5 to 0fa742b Compare June 6, 2024 14:27
@Steffy29 Steffy29 requested a review from ghyenne June 6, 2024 14:28
feat(telecom-dashboard): add ftth eligibilities list
7002761 
ref: UXCT-549

Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com>
@Steffy29 Steffy29 force-pushed the UXCT-549-internet-access-ftth-eligibility-view branch from 0fa742b to 7002761 Compare June 7, 2024 13:24
antonymarion
antonymarion previously approved these changes Jun 7, 2024
View reviewed changes
ghyenne
ghyenne previously approved these changes Jun 10, 2024
View reviewed changes
@ovh-cds
fix(i18n): add missing translations [CDS 61]
25c8160 
Signed-off-by: CDS Translator Agent <opensource@ovh.net>
@antleblanc antleblanc dismissed stale reviews from ghyenne and antonymarion via 25c8160 June 21, 2024 14:43
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 21, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@qpavy qpavy changed the base branch from develop to release/components-w27 June 27, 2024 12:42
@qpavy qpavy merged commit cdcad03 into release/components-w27 Jun 27, 2024
14 of 15 checks passed
@qpavy qpavy deleted the UXCT-549-internet-access-ftth-eligibility-view branch June 27, 2024 12:50
@qpavy qpavy mentioned this pull request Jun 27, 2024
Merged
14 tasks
qpavy pushed a commit that referenced this pull request Jul 1, 2024
@Steffy29 @ovh-cds
feat(telecom.dashboard): add ftth eligibilities list (#11855)
5909446 
ref: UXCT-549

Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qpavy qpavy qpavy approved these changes

@acavalloni acavalloni acavalloni approved these changes

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti was automatically assigned from ovh/team-manager-dev-angularjs

@stif59100 stif59100 Awaiting requested review from stif59100

@antonymarion antonymarion Awaiting requested review from antonymarion

@ghyenne ghyenne Awaiting requested review from ghyenne

Assignees

@Steffy29 Steffy29

Labels
quality check: ok translation required universe-telecom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Steffy29 @qpavy @acavalloni @antonymarion @ghyenne @stif59100