Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/manager 14005 #11896

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Feat/manager 14005 #11896

merged 1 commit into from
Jun 10, 2024

Conversation

vovh
Copy link
Contributor

@vovh vovh commented Jun 5, 2024 •
edited
Loading

Question Answer
Branch? feat/key-management-service
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-14005
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

As a customer, I want to view KMS details, and make actions on it (edit information and encryption methods)

Related

@vovh vovh changed the base branch from master to feat/key-management-service June 5, 2024 07:28
@vovh vovh marked this pull request as ready for review June 6, 2024 07:51
@vovh vovh requested review from a team as code owners June 6, 2024 07:51
@vovh vovh requested review from kqesar, frenautvh, qpavy, antonymarion and anooparveti and removed request for a team June 6, 2024 07:51
@vovh
feat(key-management-service): add billing section in dashboard
3da3334 
ref: MANAGER-14005

Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
9.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@vovh vovh merged commit a6f1916 into feat/key-management-service Jun 10, 2024
12 of 14 checks passed
@vovh vovh deleted the feat/MANAGER-14005 branch June 10, 2024 15:39
vovh added a commit that referenced this pull request Jun 12, 2024
@vovh
Merge pull request #11896 from ovh/feat/MANAGER-14005
918ca13 
Feat/manager 14005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darsene darsene darsene approved these changes

@rjamet-ovh rjamet-ovh rjamet-ovh approved these changes

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
enabler feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vovh @darsene @rjamet-ovh