Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci.savings-plan): add savings plan micro-app #11936

Merged
merged 68 commits into from
Jun 27, 2024
Merged

feat(pci.savings-plan): add savings plan micro-app #11936

merged 68 commits into from
Jun 27, 2024

Conversation

brofik
Copy link
Contributor

@brofik brofik commented Jun 7, 2024

Question Answer
Branch? feat/pci-savings-plan
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #TAPC-1084
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@brofik brofik requested review from a team as code owners June 7, 2024 07:21
@brofik brofik requested review from sidlynx, frenautvh, antonymarion, oalkabouss and mhelhali-soufien and removed request for a team June 7, 2024 07:21
@lionel95200x lionel95200x force-pushed the feat/TAPC-1084 branch 2 times, most recently from 0d70214 to 475086a Compare June 17, 2024 11:51
@github-actions github-actions bot added universe-public-cloud has conflicts Has conflicts to resolve before merging labels Jun 17, 2024
anooparveti
anooparveti reviewed Jun 17, 2024
View reviewed changes
packages/manager/apps/pci-savings-plan/src/index.tsx
Comment on lines +15 to +22
const trackingContext = {
chapter1: UNIVERSE,
chapter2: SUB_UNIVERSE,
chapter3: APP_NAME,
appName: APP_NAME,
pageTheme: UNIVERSE,
level2Config: LEVEL2,
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Can you update the variables with the right values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the values UNIVERS, SUB_UNIVERS, ... are not literals, they are constants defined and initialized in the file packages/manager/apps/pci-savings-plan/src/tracking.constant.ts

anooparveti
anooparveti reviewed Jun 17, 2024
View reviewed changes
packages/manager/apps/pci-savings-plan/src/pages/listing/index.tsx
queryKey: [`servicesListingIceberg`],
queryFn: ({ pageParam }) =>
getListingIcebergV2({ projectId, pageSize, cursor: pageParam }),
staleTime: Infinity,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How so ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

['project', projectId, 'savings-plan']

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@brofik brofik requested a review from chipp972 June 26, 2024 05:56
vovh and others added 8 commits June 26, 2024 12:28
@vovh
fix(container): fix issue with kms menu entry in pci menu (#12137)
c6677cb 
ref: MANAGER-13791

Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
@lionel95200x @ovh-cds
fix(i18n): add missing translations [CDS 3111]
c6f9bde 
Signed-off-by: CDS Translator Agent <opensource@ovh.net>
@qpavy
perf(dedicated.server): fetch server list without details (#12088)
5ed064b 
ref: MANAGER-14260

Signed-off-by: Quentin Pavy <quentin.pavy.ext@ovhcloud.com>
@darsene
Merge pull request #12148 from ovh/release/incidents-w26
08fca9a 
New release - Incidents w26
@darsene @ovh-cds
release: samarium-lizard
5ba7a79 
Signed-off-by: ovh-cds <opensource@ovh.net>
@anooparveti
sync: master to develop
3f9dbe9 
Signed-off-by: Anoop N <anoop.n@ovhcloud.com>
@anooparveti
Merge pull request #12161 from ovh/sync/master-develop
b046ddd 
Sync/master develop
feat(pci.savings-plan): create savings plan micro-app
6982d39 
ref: TAPC-1084
Signed-off-by: Rafik Adiche <rafik.adiche.ext@corp.ovh.com>
@github-actions GitHub Actions
Copy link
Contributor

yarn.lock changes

Summary

Status Count
UPDATED 66
Click to toggle table visibility
Name Status Previous Current
@adobe/css-tools UPDATED 4.3.2 4.4.0
@esbuild/aix-ppc64 UPDATED 0.19.11 0.20.2
@esbuild/android-arm UPDATED 0.19.11 0.20.2
@esbuild/android-arm64 UPDATED 0.19.11 0.20.2
@esbuild/android-x64 UPDATED 0.19.11 0.20.2
@esbuild/darwin-arm64 UPDATED 0.19.11 0.20.2
@esbuild/darwin-x64 UPDATED 0.19.11 0.20.2
@esbuild/freebsd-arm64 UPDATED 0.19.11 0.20.2
@esbuild/freebsd-x64 UPDATED 0.19.11 0.20.2
@esbuild/linux-arm UPDATED 0.19.11 0.20.2
@esbuild/linux-arm64 UPDATED 0.19.11 0.20.2
@esbuild/linux-ia32 UPDATED 0.19.11 0.20.2
@esbuild/linux-loong64 UPDATED 0.19.11 0.20.2
@esbuild/linux-mips64el UPDATED 0.19.11 0.20.2
@esbuild/linux-ppc64 UPDATED 0.19.11 0.20.2
@esbuild/linux-riscv64 UPDATED 0.19.11 0.20.2
@esbuild/linux-s390x UPDATED 0.19.11 0.20.2
@esbuild/linux-x64 UPDATED 0.19.11 0.20.2
@esbuild/netbsd-x64 UPDATED 0.19.11 0.20.2
@esbuild/openbsd-x64 UPDATED 0.19.11 0.20.2
@esbuild/sunos-x64 UPDATED 0.19.11 0.20.2
@esbuild/win32-arm64 UPDATED 0.19.11 0.20.2
@esbuild/win32-ia32 UPDATED 0.19.11 0.20.2
@esbuild/win32-x64 UPDATED 0.19.11 0.20.2
@ovhcloud/ods-common-testing UPDATED 17.2.1 17.2.2
@rollup/rollup-android-arm-eabi UPDATED 4.16.4 4.18.0
@rollup/rollup-android-arm64 UPDATED 4.16.4 4.18.0
@rollup/rollup-darwin-arm64 UPDATED 4.16.4 4.18.0
@rollup/rollup-darwin-x64 UPDATED 4.16.4 4.18.0
@rollup/rollup-linux-arm-gnueabihf UPDATED 4.16.4 4.18.0
@rollup/rollup-linux-arm-musleabihf UPDATED 4.16.4 4.18.0
@rollup/rollup-linux-arm64-gnu UPDATED 4.16.4 4.18.0
@rollup/rollup-linux-arm64-musl UPDATED 4.16.4 4.18.0
@rollup/rollup-linux-powerpc64le-gnu UPDATED 4.16.4 4.18.0
@rollup/rollup-linux-riscv64-gnu UPDATED 4.16.4 4.18.0
@rollup/rollup-linux-s390x-gnu UPDATED 4.16.4 4.18.0
@rollup/rollup-linux-x64-gnu UPDATED 4.16.4 4.18.0
@rollup/rollup-linux-x64-musl UPDATED 4.16.4 4.18.0
@rollup/rollup-win32-arm64-msvc UPDATED 4.16.4 4.18.0
@rollup/rollup-win32-ia32-msvc UPDATED 4.16.4 4.18.0
@rollup/rollup-win32-x64-msvc UPDATED 4.16.4 4.18.0
@tanstack/query-core UPDATED 5.29.0 5.36.1
@tanstack/query-devtools UPDATED 5.28.10 5.37.1
@tanstack/react-query UPDATED 5.29.2 5.37.1
@tanstack/react-query-devtools UPDATED 5.29.2 5.37.1
@tanstack/react-table UPDATED 8.11.8 8.17.3
@tanstack/table-core UPDATED 8.11.8 8.17.3
@testing-library/dom UPDATED 9.3.4 10.1.0
@testing-library/jest-dom UPDATED 6.4.2 6.4.6
@testing-library/react UPDATED 14.2.1 16.0.0
@vitest/expect UPDATED 1.2.2 1.6.0
@vitest/runner UPDATED 1.2.2 1.6.0
@vitest/snapshot UPDATED 1.2.2 1.6.0
@vitest/spy UPDATED 1.2.2 1.6.0
@vitest/utils UPDATED 1.2.2 1.6.0
aria-query UPDATED 5.1.3 5.3.0
esbuild UPDATED 0.19.11 0.20.2
js-tokens UPDATED 4.0.0 9.0.0
postcss UPDATED 8.4.35 8.4.38
rollup UPDATED 4.16.4 4.18.0
strip-literal UPDATED 1.3.0 2.1.0
tailwindcss UPDATED 3.4.1 3.4.3
tinypool UPDATED 0.8.2 0.8.4
vite UPDATED 5.0.11 5.2.13
vite-node UPDATED 1.2.2 1.6.0
vitest UPDATED 1.2.2 1.6.0

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

chipp972
chipp972 previously approved these changes Jun 27, 2024
View reviewed changes
@chipp972 chipp972 dismissed their stale review June 27, 2024 12:24

need rebase I think

@lionel95200x lionel95200x merged commit 7c873fd into feat/pci-savings-plan Jun 27, 2024
10 of 14 checks passed
@lionel95200x lionel95200x deleted the feat/TAPC-1084 branch June 27, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selm3n selm3n selm3n approved these changes

@chipp972 chipp972 chipp972 left review comments

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion was automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien was automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud Awaiting requested review from aboungnaseng-ovhcloud

Assignees
No one assigned
Labels
container continuous-integration Changes to our CI configuration files and scripts dependencies Pull requests that update a dependency file documentation Documentation only changes enabler feature New feature manager-components sign-up translation required universe-bare-metal-cloud universe-hosted-private-cloud universe-hub universe-public-cloud universe-telecom universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet