Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vrack-services): improve subnet edit modal #12032

Open
wants to merge 1 commit into
base: feat/epic-vrack-services-13871
Choose a base branch
from
Open

feat(vrack-services): improve subnet edit modal #12032

wants to merge 1 commit into from

Conversation

chipp972
Copy link
Contributor

ref: MANAGER-11254

Question Answer
Branch? feat/epic-vrack-services-13871
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-11254
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@chipp972 chipp972 requested review from a team as code owners June 14, 2024 14:12
@chipp972 chipp972 requested review from sidlynx, frenautvh, qpavy, antonymarion and ghyenne and removed request for a team June 14, 2024 14:12
@chipp972 chipp972 force-pushed the feat/vrack-services-11254 branch 4 times, most recently from 71afd9a to 05243d4 Compare June 19, 2024 08:46
@chipp972 chipp972 changed the title feat(vrack-services): edit the subnet feat(vrack-services): improve subnet edit modal Jun 19, 2024
@chipp972 chipp972 force-pushed the feat/epic-vrack-services-13871 branch from 14879dc to 23147bb Compare June 19, 2024 09:43
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jun 19, 2024
@chipp972 chipp972 force-pushed the feat/epic-vrack-services-13871 branch from 23147bb to e9e9566 Compare June 19, 2024 09:43
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jun 19, 2024
@chipp972 chipp972 force-pushed the feat/vrack-services-11254 branch 3 times, most recently from 9a9e1b8 to d6c8440 Compare June 21, 2024 13:50
@chipp972 chipp972 force-pushed the feat/epic-vrack-services-13871 branch from 8af561b to 753e5d3 Compare June 28, 2024 09:50
@chipp972 chipp972 requested a review from a team as a code owner June 28, 2024 09:50
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jun 28, 2024
@chipp972 chipp972 force-pushed the feat/epic-vrack-services-13871 branch from 753e5d3 to 78521b9 Compare June 28, 2024 09:51
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jun 28, 2024
@chipp972
Copy link
Contributor Author

chipp972 commented Jul 1, 2024

Waiting for translations

@chipp972 chipp972 force-pushed the feat/epic-vrack-services-13871 branch from 78521b9 to 38446c9 Compare July 4, 2024 12:58
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jul 4, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jul 4, 2024
feat(vrack-services): improve edit subnet modal
4f7b70b 
ref: MANAGER-11254

Signed-off-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qpavy qpavy qpavy approved these changes

@anooparveti anooparveti anooparveti approved these changes

@sachinrameshn sachinrameshn sachinrameshn approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature quality check: ok translation required universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chipp972 @qpavy @anooparveti @sachinrameshn