feat: update pci menu to support bff for db react app #12073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jperchoc
requested changes
Jun 19, 2024
...manager/apps/container/src/container/legacy/server-sidebar/universe/public-cloud/pci-menu.ts
Outdated
Show resolved
Hide resolved
...manager/apps/container/src/container/legacy/server-sidebar/universe/public-cloud/pci-menu.ts
Outdated
Show resolved
Hide resolved
...r/apps/container/src/container/nav-reshuffle/sidebar/navigation-tree/services/publicCloud.ts
Outdated
Show resolved
Hide resolved
...r/apps/container/src/container/nav-reshuffle/sidebar/navigation-tree/services/publicCloud.ts
Outdated
Show resolved
Hide resolved
jperchoc
previously approved these changes
Jun 19, 2024
darsene
requested changes
Jun 20, 2024
There was a problem hiding this comment.
@abullet33 :
Can you update your pull request with those following elements please ?
- description part is not filled
- commit message is not compliant (feat(app): ...)
- ticket reference in the commit message is not well set (ref: XXX)
...r/apps/container/src/container/nav-reshuffle/sidebar/navigation-tree/services/publicCloud.ts
Show resolved
Hide resolved
abullet33
force-pushed
the
feat/update-menu-for-pci-databases-analytics-app
branch
from
5ff6bc8
to
bf9efc9
Compare
abullet33
force-pushed
the
feat/update-menu-for-pci-databases-analytics-app
branch
from
bf9efc9
to
3145122
Compare
abullet33
force-pushed
the
feat/update-menu-for-pci-databases-analytics-app
branch
from
3145122
to
c6fcf48
Compare
github-actions
bot
added
universe-web-cloud
universe-bare-metal-cloud
universe-telecom
translation required
dependencies
jperchoc
previously approved these changes
Jun 20, 2024
darsene
previously approved these changes
Jun 20, 2024
abullet33
force-pushed
the
feat/update-menu-for-pci-databases-analytics-app
branch
from
c6fcf48
to
ef916e0
Compare
github-actions
bot
removed
universe-web-cloud
universe-bare-metal-cloud
universe-telecom
translation required
dependencies
ref : DATATR-1090 Signed-off-by: Arthur Bullet <arthur.bullet@ovhcloud.com>
abullet33
force-pushed
the
feat/update-menu-for-pci-databases-analytics-app
branch
from
ef916e0
to
f1345b7
Compare
github-actions
bot
added
translation required
dependencies
abullet33
changed the base branch from
develop
to
feat/pci-databases-analytics-epic
|
jperchoc
approved these changes
Jun 28, 2024
jperchoc
approved these changes
Jun 28, 2024
jperchoc
merged commit 8d94103
into
feat/pci-databases-analytics-epic
8 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datatr-1090
developDescription
Modifying both PCI Menu to handle soft and progressive react migration. New keys have been added in BFF and need to be merged before.
Related
DATATR-1090