feat(container): bullet added on pnr lvl 2 #12108
Conversation
ref: MANAGER-14442 Signed-off-by: Omar ALKABOUSS MOUSSANA <omar.alkabouss-moussana.ext@corp.ovh.com>
oalkabouss
requested review from
sidlynx,
seven-amid,
antonymarion,
anooparveti and
darsene
packages/manager/apps/container/src/container/nav-reshuffle/sidebar/index.tsx
Outdated
Show resolved
Hide resolved
| @@ -303,5 +303,6 @@ | |||
| .sidebarLinkTag { | |||
| width: 0.8rem; | |||
| margin-right: .25rem; | |||
| float: right; | |||
There was a problem hiding this comment.
Not other solution than using a float here ?
There was a problem hiding this comment.
Yes, there are other solutions, like flex for example, but when I apply the flex display the tags appear oddly so I don't like to touch the case of other components to just align the dot icon right
There was a problem hiding this comment.
The issue with float is not to add css, but to use a float that not works correctly on this context. It's not vertically aligned with the text. You can try to wrap the icon like in sidebarLink to align vertically and use a justify content space between on the link the keep the dot on the right.
ref: MANAGER-14442 Signed-off-by: Omar ALKABOUSS MOUSSANA <omar.alkabouss-moussana.ext@corp.ovh.com>
oalkabouss
force-pushed
the
feat/MANAGER-14442
branch
from
4ad1199
to
de00dbb
Compare
|
ref: MANAGER-14442
masterOnly FR translations have been updatedBreaking change is mentioned in relevant commitsDescription
PNR v2: bullet added on lvl 2 to indicate an existing product.
Related