Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sms.senders): add column to display sender reason of reject #240

Merged
merged 2 commits into from Mar 8, 2019
Merged

feat(sms.senders): add column to display sender reason of reject #240

merged 2 commits into from Mar 8, 2019

Conversation

Steffy29
Copy link
Contributor

@Steffy29 Steffy29 commented Mar 6, 2019

Ref: UXCT-99

antleblanc
antleblanc reviewed Mar 6, 2019
View reviewed changes
Copy link
Member

@antleblanc antleblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the scope to your commit message?

Example:

feat(sms.senders): ...

Thanks:)

packages/manager/modules/sms/package.json Show resolved Hide resolved
@Steffy29
Copy link
Contributor Author

Steffy29 commented Mar 7, 2019

@antleblanc I rebased the commit message.

@Steffy29 Steffy29 changed the title feat: add column to display sender reason of reject feat(sms.senders): add column to display sender reason of reject Mar 7, 2019
@antleblanc
Copy link
Member

@Steffy29 Some commits has been squashed on the develop branch. Could you please rebase yours? Thanks!

@Steffy29
Copy link
Contributor Author

Steffy29 commented Mar 7, 2019

@antleblanc rebase done

@Steffy29 Steffy29 force-pushed the feat/sms-sender-reject branch 2 times, most recently from 86b14c9 to 2061588 Compare March 7, 2019 15:53
@antleblanc
Copy link
Member

@Steffy29 I'm not sure that you've rebase correctly.

Normally you should have these two commit only:

feat(sms.senders): add column to display sender reason of reject
build: add needed dependencies

@Steffy29
Copy link
Contributor Author

Steffy29 commented Mar 8, 2019

OK. I tried many rebases yesterday and it was the best result I could have. I don't understand why I had all those commits in my PR.

@jleveugle jleveugle merged commit c843b94 into develop Mar 8, 2019
@jleveugle jleveugle deleted the feat/sms-sender-reject branch March 8, 2019 10:15
This was referenced Mar 8, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antleblanc antleblanc antleblanc left review comments

@jleveugle jleveugle jleveugle approved these changes

@cbourgois cbourgois Awaiting requested review from cbourgois

@frenautvh frenautvh Awaiting requested review from frenautvh

Assignees
No one assigned
Labels
feature New feature quality check: ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Steffy29 @antleblanc @jleveugle