Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix MLS-2703 (pci.notebooks): notebook informations resources #6676

Merged
merged 8 commits into from
Apr 25, 2022
Merged

fix MLS-2703 (pci.notebooks): notebook informations resources #6676

merged 8 commits into from
Apr 25, 2022

Conversation

jperchoc
Copy link
Contributor

@jperchoc jperchoc commented Mar 11, 2022 •
edited by marie-j
Loading

MLS-2703

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #MLS-2703
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

  • Fix resources values in add notebook page
  • Fix resources values in general information page
  • Add workspace storage information
  • Add a confirm modal before stopping a notebook

🎏 Translations

  • TRANS-42698

@jperchoc jperchoc force-pushed the fix/MLS-2703-notebook-informations-resources branch from 9c77df1 to df20b09 Compare March 16, 2022 09:15
@jperchoc jperchoc marked this pull request as ready for review March 16, 2022 12:55
@jperchoc jperchoc requested a review from a team as a code owner March 16, 2022 12:55
anooparveti
anooparveti previously approved these changes Mar 16, 2022
View reviewed changes
anooparveti
anooparveti previously approved these changes Mar 17, 2022
View reviewed changes
@antleblanc antleblanc added the question Further information is requested label Mar 17, 2022
@antleblanc antleblanc removed the question Further information is requested label Mar 18, 2022
@jperchoc jperchoc force-pushed the fix/MLS-2703-notebook-informations-resources branch from 2db9db3 to 56b5bc9 Compare March 24, 2022 08:57
antleblanc
antleblanc previously approved these changes Mar 24, 2022
View reviewed changes
ghyenne
ghyenne previously approved these changes Mar 25, 2022
View reviewed changes
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Apr 22, 2022
anooparveti
anooparveti previously approved these changes Apr 22, 2022
View reviewed changes
Dimfacion
Dimfacion previously approved these changes Apr 22, 2022
View reviewed changes
@JeremyDec JeremyDec added the has conflicts Has conflicts to resolve before merging label Apr 25, 2022
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Apr 25, 2022
jperchoc and others added 8 commits April 25, 2022 09:15
@jperchoc
fix: show correct resources values for notebooks and add stop modal
96b261a 
MLS-2703

Signed-off-by: Jonathan Perchoc <jonathan.perchoc@ovhcloud.com>
@ghyenne @jperchoc
fix(public-cloud): remove beta tag on ai notebook
163e2ee 
ref: MANAGER-8885
Signed-off-by: Guillaume Hyenne <guillaume.hyenne@ovhcloud.com>
@jperchoc
fix: change wording
8864671 
MLS-2703

Signed-off-by: Jonathan Perchoc <jonathan.perchoc@ovhcloud.com>
@jperchoc
fix(i18n): add missing translations [CDS 1565]
ea508ae 
Signed-off-by: CDS Translator Agent <opensource@ovh.net>
@ghyenne @jperchoc
fix(public-cloud): fix some tracking for notebook
2f6f2a8 
ref: MANAGER-7491
Signed-off-by: Guillaume Hyenne <guillaume.hyenne@ovhcloud.com>
@jperchoc
fix: typo
2563fc7 
MLS-2703

Signed-off-by: Jonathan Perchoc <jonathan.perchoc@ovhcloud.com>
@jperchoc
fix: display progressbar even if used storage is 0
6d7be40 
MLS-2703

Signed-off-by: Jonathan Perchoc <jonathan.perchoc@ovhcloud.com>
@jperchoc
fix: remove extra spaces
fe674f5 
MLS-2703

Signed-off-by: Jonathan Perchoc <jonathan.perchoc@ovhcloud.com>
@jperchoc jperchoc force-pushed the fix/MLS-2703-notebook-informations-resources branch from c601f6a to fe674f5 Compare April 25, 2022 07:16
@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JeremyDec JeremyDec merged commit 0de1933 into master Apr 25, 2022
@JeremyDec JeremyDec deleted the fix/MLS-2703-notebook-informations-resources branch April 25, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyDec JeremyDec JeremyDec approved these changes

@cbourgois cbourgois Awaiting requested review from cbourgois cbourgois is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne

@frenautvh frenautvh Awaiting requested review from frenautvh

@antleblanc antleblanc Awaiting requested review from antleblanc

@Dimfacion Dimfacion Awaiting requested review from Dimfacion

@anooparveti anooparveti Awaiting requested review from anooparveti

Assignees
No one assigned
Labels
bug Something isn't working quality check: ok universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jperchoc @antleblanc @Dimfacion @anooparveti @frenautvh @JeremyDec @ghyenne